feat: add setting to ignore effect for damage rolls #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin9257
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Nov 18, 2023
# [4.6.0](v4.5.2...v4.6.0) (2023-11-18) ### Features * add setting to ignore effect for damage rolls ([#1496](#1496)) ([f83651c](f83651c))
|
🎉 This PR is included in version 4.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature and Bug fix
What is the current behavior? (You can also link to an open issue here)
Damage rolls always include the skill roll effect
TwodsixDiceRolls not exposed to core system
Autocomplete error for characteristics after moving to template
Status conditions applied when not necessary
What is the new behavior (if this is a feature change)?
Add settings and code to have damage rolls ignore effect
Add TwodsixDiceRolls to system
Fix characteristic displays for Autocomplete
Apply status conditions when there is a real change in state
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
NO
Other information: