feat: New Enhancer Buttons for Journal pages #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add SkillRoll enrichment add JSDoc add localizations
marvin9257
changed the title
marvin9257
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Dec 8, 2023
# [4.9.0](v4.8.0...v4.9.0) (2023-12-08) ### Features * New Enhancer Buttons for Journal pages ([#1506](#1506)) ([7fa5a85](7fa5a85))
|
🎉 This PR is included in version 4.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
No direct ability to display roll table in Journal Entry
Can't make complex skill rolls without macro
What is the new behavior (if this is a feature change)?
Add @DisplayRollTable enricher.
Add @SkillRoll enricher.
Described here: https://github.com/xdy/twodsix-foundryvtt/wiki/Custom-Journal-Page-Enhancers
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Refactored ship position skill roll code to use parsing across both code bases