zephyr-dom0-xt: Add vchan simple echo server #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klogg
requested changes
Jun 18, 2024
firscity
reviewed
Jun 19, 2024
dsemenets
force-pushed
the
echo_srv
branch
2 times, most recently
from
36de73a
to
02889cb
Compare
|
Fixed comments |
|
There should readme update with full example as from dom0 side as from doimu side |
|
Updated README.rst |
GrygiriiS
reviewed
Jun 20, 2024
oleksiimoisieiev
suggested changes
Jun 20, 2024
GrygiriiS
reviewed
Jun 20, 2024
|
|
lorc
requested changes
Jun 20, 2024
| vchan_server_stop = 1; | ||
| if (k_thread_join(pecho_thread, K_MSEC(1000))) { | ||
| shell_error(sh, "Killing thread"); | ||
| k_thread_abort(pecho_thread); |
There was a problem hiding this comment.
Could you please confirm that functions used in peacho_thread does not use dynamic allocation? Otherwise, we will get resource leak here.
There was a problem hiding this comment.
pecho_thread is pointer to echo_thread static structure or NULL (line 74)
dsemenets
force-pushed
the
echo_srv
branch
2 times, most recently
from
2a0234d
to
1c4c046
Compare
|
LGTM |
dsemenets
force-pushed
the
echo_srv
branch
2 times, most recently
from
3d8638d
to
4b63643
Compare
|
Rebased to main |
lorc
approved these changes
Jul 2, 2024
firscity
reviewed
Jul 10, 2024
There was a problem hiding this comment.
Acked-by: Dmytro Firsov <[email protected]>
Also, @klogg can you please re-check?
|
Add vchan simple echo server. Server opens channel and all incoming
data will be send back. Server will be enabled with option
CONFIG_VCHAN_SHELL_CMDS. Server introduces 2 commands:
vchan start [domid]
Start echo server. domid - The peer domain that will be connecting
(0 by default)
vchan stop
Stop server
Updated README.rst with information about vchan echo server
Signed-off-by: Dmytro Semenets <[email protected]>
Reviewed-by: Grygorii Strashko <[email protected]>
Acked-by: Oleksii Moisieiev <[email protected]>
Acked-by: Volodymyr Babchuk <[email protected]>
Acked-by: Dmytro Firsov <[email protected]>
Reviewed-by: Artem Mygaiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add vchan simple echo server. Server opens channel and all incoming data will be send back.