Xenlib misc updates and fixes #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorc
approved these changes
May 7, 2024
| @@ -1044,26 +1044,15 @@ static int dom0less_init(void) | |||
|
|
|||
| static int init_domain0(void) | |||
| { | |||
| struct xen_domctl_getdomaininfo dominfo; | |||
There was a problem hiding this comment.
Taking into account size of xen_domctl_getdomaininfo it is debatable if we should store it in the stack. Better to have -ENOMEM than stack overrun.
|
Oh, and one more thing. Please configure spell checker in your editor, so we can avoid things like "but there is |
added 5 commits
May 8, 2024 18:28
With CONFIG_XEN_SHELL=n build unused functions warnings observed, so fix it. Signed-off-by: Grygorii Strashko <[email protected]> Reviewed-by: Volodymyr Babchuk <[email protected]>
The XENSTORE_TREE_TRAVERSE_DEPTH is used in xss_list_traverse() which is generic even if it's used now only form xenlib SHELL code. Signed-off-by: Grygorii Strashko <[email protected]> Reviewed-by: Volodymyr Babchuk <[email protected]>
The init_domain0() is using XSTAT features to get Dom0 info, but there is more simple way is to use xen_domctl_getdomaininfo() API. Hence, use xen_domctl_getdomaininfo() to simplify the code and get rid from XSTAT dependencies. Also -1 k_malloc. The size of struct xen_domctl_getdomaininfo is 120 bytes and It is initcall, so safe to allocate on stack. Signed-off-by: Grygorii Strashko <[email protected]> Reviewed-by: Volodymyr Babchuk <[email protected]>
The "pragma once" is not generic approach for Zephyr to prevent recursive headers inclusion. Get rid of it. Signed-off-by: Grygorii Strashko <[email protected]> Reviewed-by: Volodymyr Babchuk <[email protected]>
No need to send ESCAPE_CHARACTER Ctrl-'[' to guest domain, just return from console_shell_cb(). Signed-off-by: Grygorii Strashko <[email protected]> Reviewed-by: Volodymyr Babchuk <[email protected]>
GrygiriiS
force-pushed
the
xenlib-rpi5_dev_misc
branch
from
c1bee1b
to
4eb964c
Compare
|
@firscity, could you please merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set of misc, not critical updates and fixes.