findXenSourceBackups: log any exception caught

- it is bad practice to "catch any" - not logging anything just hides information, which can be especially important here as the reason for a try/catch is not obvious (exceptions thrown by XenServerBackup.__init__?) Signed-off-by: Yann Dirson <[email protected]>
xenserver · Oct 6, 2023 · 54ae140 · 54ae140
1 parent 51f75da
commit 54ae140
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/product.py b/product.py
@@ -545,7 +545,8 @@ def findXenSourceBackups():
                                (backup.version, THIS_PLATFORM_VERSION))
                 else:
                     backups.append(backup)
-        except:
+        except Exception as ex:
+            logger.log("findXenSourceBackups caught exception for partition %s: %s" % (p, ex))
             pass
         if b:
             b.unmount()