CP-50298: Support restoring dir to specified mode and user/group #187
Conversation
attributes Signed-off-by: Deli Zhang <[email protected]> (cherry picked from commit 0ccfe46)
|
Will merge in PI26 |
| def copy_ownership(src_root, src_path, dst_root, dst_path): | ||
| # Copy attributes from a path in a source root to another path in a | ||
| # destination root. | ||
| # - The ownership is copied such that it is notaffected by changes |
There was a problem hiding this comment.
typo: notaffected -> not affected
| # destination root. | ||
| # - The ownership is copied such that it is notaffected by changes | ||
| # in the underlying uid/gid. Or it's set to the specified. | ||
| # - The mode is set to the specified. |
There was a problem hiding this comment.
Not an English native speaker but I think specified needs something after like specified one. I would change to The mode is set to the specified one if present.
|
I cannot push fix code. Can admin give me |
You should not use |
This change was already reviewed before #170 (#168) from private to feature. Now to merge to target release/xs8 from feature. |
You'll need to open a PR to the feature branch, once merged that will update this PR |
|
Fixed in PR #191 |
attributes
Signed-off-by: Deli Zhang [email protected]
(cherry picked from commit 0ccfe46)