-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship systemd config file for sshpassword support #42
Open
ydirson
wants to merge
2
commits into
xenserver:master
Choose a base branch
from
xcp-ng:for-xs/sshd
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydirson
added a commit
to xcp-ng/xcp
that referenced
this pull request
Apr 4, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged.
ydirson
added a commit
to xcp-ng/xcp
that referenced
this pull request
Apr 6, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged.
ydirson
added a commit
to xcp-ng/xcp
that referenced
this pull request
Apr 17, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged.
ydirson
added a commit
to xcp-ng/xcp
that referenced
this pull request
Apr 17, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged.
ydirson
added a commit
to xcp-ng/xcp
that referenced
this pull request
Apr 18, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged.
ydirson
added a commit
to xcp-ng/xcp
that referenced
this pull request
Apr 18, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged.
ydirson
added a commit
to xcp-ng/xcp
that referenced
this pull request
Apr 18, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged.
ydirson
added a commit
to xcp-ng/xcp
that referenced
this pull request
Apr 19, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged.
ydirson
added a commit
to xcp-ng/xcp
that referenced
this pull request
Jun 15, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged. Signed-off-by: Yann Dirson <[email protected]>
ydirson
added a commit
to xcp-ng/create-install-image
that referenced
this pull request
Jun 15, 2023
This should indeed be part of host-installer-startup, see xenserver/host-installer#42 Will need to be reverted when that PR is merged. Signed-off-by: Yann Dirson <[email protected]>
freddy77
reviewed
Dec 8, 2023
freddy77
previously approved these changes
Dec 15, 2023
@ydirson I think you should add some reviewers to this PR |
@freddy77 I don't think we have enough credentials on this repo for this. |
Added some reviewer. |
@ydirson can you rebase on |
The sshpassword commandline parameter is documented in doc/ but is implemented in this file which was not shipped as part of the installer itself. Signed-off-by: Yann Dirson <[email protected]>
Suggested-by: Frediano Ziglio <[email protected]> Signed-off-by: Yann Dirson <[email protected]>
rebased |
freddy77
approved these changes
Jan 14, 2025
@rosslagerwall @GeraldEV @liulinC can you review this? It has been pending for a huge time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sshpassword commandline parameter is documented in doc/ but
is implemented in this file which was not shipped as part of the
installer itself.