Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New
ViewManager
for persisting named bundles of grid and other component state #3774New
ViewManager
for persisting named bundles of grid and other component state #3774Changes from 11 commits
9b02ead
09db08d
b4b177c
b91d766
8b1eb9c
e99cd7c
e58e1be
0bf7539
b9b9447
78d95fc
becede0
103dafa
0c591d2
9ca0fab
c71ebfe
2982458
afd6f7e
3ee7367
bacb760
ee1beff
a01060e
bb518f5
7ae18ec
9391c64
ac6e397
c5536e2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To discuss - either exporting the dialogs, exposing more props for customizing, or making them pluggable (i.e.
PersistenceManagerProps
could accept amanageDialogCmp
andsaveDialogCmp
that default to our Hoist implementations)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discuss today - Reset vs Restore. Or maybe there’s a better phrasing entirely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a little favorite star icon to the right of the view?