Update _load_sbert_model Parameters and Fix Tokenize Padding #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses two significant updates to the
InstructorEmbedding
functionality to improve compatibility and performance when using sentence-transformers version 3.0.1.Changes Introduced:
Refactor: Added Missing Parameters to
_load_sbert_model
for Enhanced Compatibilitylocal_files_only=False
model_kwargs=None
tokenizer_kwargs=None
config_kwargs=None
Refactor: Updated
tokenize
Method's Padding Parameter Back toTrue
padding
parameter from"max_length"
back toTrue
.Performance Comparison:
With
padding=True
:With
padding="max_length"
:Additional Note
Testing:
Please review the changes and let me know if any further adjustments are necessary.
Thank you for considering this request. I look forward to your feedback.