-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update folly to 2024.10.07 #5505
Conversation
Version 2024.10.14 introduced an incompatibility with an older version of MSVC in this commit: So I suggest to skip this version for now and update to the latest working version on all platforms, so as not to add unnecessary patches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG.
void test() { | ||
folly::AsyncIOOp asyncIOOp; | ||
} | ||
]]}, {configs = {languages = "c++17"}, includes = "folly/experimental/io/AsyncIO.h"})) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The headers have been moved in the commit at: facebook/folly@e5d54e8. You may need to update these includes accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My idea was to keep the old include in order not to break tests with old folly revisions.
For now, backwards support for including these files is preserved:
https://github.com/facebook/folly/blob/main/folly/experimental/io/AsyncIO.h
https://github.com/facebook/folly/blob/main/folly/experimental/io/IoUring.h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense.
No description provided.