Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ginkgo cuda #5507

Merged
merged 4 commits into from
Oct 16, 2024
Merged

fix ginkgo cuda #5507

merged 4 commits into from
Oct 16, 2024

Conversation

xq114
Copy link
Contributor

@xq114 xq114 commented Oct 15, 2024

No description provided.

@xq114
Copy link
Contributor Author

xq114 commented Oct 16, 2024

set_policy("package.cmake_generator.ninja", false) 对xmake 3.0好像不管用?这里怎么设置不用ninja呢? @waruqi

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Adding set_policy("package.cmake_generator.ninja", false) doesn't seem to work for xmake 3.0? How to set it up without using ninja? @waruqi

@star-hengxing
Copy link
Contributor

可能对比下编译参数打 patch 更好,cmake 给 msbuild 和 ninja 分发的参数不一样小概率会出问题。。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


It may be better to patch the compilation parameters in comparison. The parameters distributed by cmake to msbuild and ninja are different, and there is a small probability that problems will occur. .

@xq114
Copy link
Contributor Author

xq114 commented Oct 16, 2024

可能对比下编译参数打 patch 更好,cmake 给 msbuild 和 ninja 分发的参数不一样小概率会出问题。。

这里是cmake的CMAKE_EXPORT_ALL_SYMBOLS有bug导致的,没法调,vcpkg那边也是禁用ninja了

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


It may be better to compare and patch the compilation parameters. The parameters distributed by cmake to msbuild and ninja are different, and there is a small probability that problems will occur. .

This is caused by a bug in cmake's CMAKE_EXPORT_ALL_SYMBOLS, which cannot be adjusted. Ninja is also disabled on vcpkg.

@waruqi
Copy link
Member

waruqi commented Oct 16, 2024

set_policy("package.cmake_generator.ninja", false) 对xmake 3.0好像不管用?这里怎么设置不用ninja呢? @waruqi

rerun 下,应该可以了

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Adding set_policy("package.cmake_generator.ninja", false) doesn't seem to work for xmake 3.0? How to set it up without using ninja? @waruqi

After rerun, it should be fine.

@xq114 xq114 merged commit 9b5eeb8 into xmake-io:dev Oct 16, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants