ZBar: add package #5530
Merged
ZBar: add package #5530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waruqi
reviewed
Oct 18, 2024
packages/z/zbar/xmake.lua
Outdated
| io.gsub("include/config.h.in", "# ?undef (.-)\n", "${define %1}\n") | ||
| os.cp(path.join(package:scriptdir(), "port", "xmake.lua"), "xmake.lua") | ||
|
|
||
| local config = { vers = package:version_str() } |
waruqi
reviewed
Oct 18, 2024
packages/z/zbar/xmake.lua
Outdated
|
|
||
| -- get LIB_VERSION from configure.ac | ||
| -- format: AC_SUBST([LIB_VERSION], [3:0:3]) | ||
| configure_ac = io.readfile("configure.ac") |
waruqi
reviewed
Oct 18, 2024
packages/z/zbar/xmake.lua
Outdated
| end | ||
| end | ||
|
|
||
| import("package.tools.xmake").install(package,config) |
waruqi
reviewed
Oct 18, 2024
packages/z/zbar/xmake.lua
Outdated
| end | ||
|
|
||
| if is_plat("macosx") then | ||
| add_deps("libiconv", {system = true}) |
There was a problem hiding this comment.
libiconv will find and use system libs first. so you need not add system = true
waruqi
reviewed
Oct 18, 2024
packages/z/zbar/port/xmake.lua
Outdated
| add_requires("libiconv") | ||
|
|
||
| -- add options | ||
| option("enable_codebar") |
waruqi
reviewed
Oct 18, 2024
packages/z/zbar/port/xmake.lua
Outdated
| set_description("whether to build support for " .. code.description) | ||
|
|
||
| on_check(function (option) | ||
| local enabled_codes = option:dep("enable-codes"):value() |
There was a problem hiding this comment.
I didn't see it in tools.xmake.install.
waruqi
reviewed
Oct 18, 2024
packages/z/zbar/port/xmake.lua
Outdated
| add_requires("libiconv") | ||
|
|
||
| -- add options | ||
| option("enable-codes") |
waruqi
reviewed
Oct 18, 2024
| if is_plat("linux", "bsd") then | ||
| add_syslinks("pthread") | ||
| end | ||
|
|
There was a problem hiding this comment.
no any add_configs to set xxx codes options in port/xmake.lua
There was a problem hiding this comment.
Oh, we do need configs in the package description.
By the way, which form is better?
xrepo install -f "qr=true" zbarxrepo install -f "codes=qr" zbar
For reference, the original configure shell script uses options like the following:
./configure --disable-video --without-gtk --without-python --enable-shared=yes --enable-static=yes --with-pic --enable-codes=ean,databar
There was a problem hiding this comment.
you can use single codes option/config
add_requires("xxx", configs = {codecs = {"qr", "ean", ...})
waruqi
reviewed
Oct 19, 2024
packages/z/zbar/port/xmake.lua
Outdated
| patch_ver = vers[3] or "" | ||
| set_configvar("ZBAR_VERSION_MAJOR", major_ver, {quote = false}) | ||
| set_configvar("ZBAR_VERSION_MINOR", minor_ver, {quote = false}) | ||
| set_configvar("ZBAR_VERSION_PATCH", patch_ver, {quote = false}) |
There was a problem hiding this comment.
use set_versions, xmake has builtin vars in config.h.in
There was a problem hiding this comment.
The config.h.in file contains content like the following:
/* Program major version (before the '.') as a number */
#undef ZBAR_VERSION_MAJOR
/* Program minor version (after '.') as a number */
#undef ZBAR_VERSION_MINOR
/* Program patch version (after the second '.') as a number */
#undef ZBAR_VERSION_PATCH
I'm not sure how to handle this.
There was a problem hiding this comment.
There was a problem hiding this comment.
Should I edit config.h.in to the following?
/* Program major version (before the '.') as a number */
#define ZBAR_VERSION_MAJOR ${VERSION_MAJOR}
/* Program minor version (after '.') as a number */
#define ZBAR_VERSION_MINOR ${VERSION_MINOR}
/* Program patch version (after the second '.') as a number */
#define ZBAR_VERSION_PATCH ${VERSION_ALTER}
waruqi
reviewed
Oct 19, 2024
packages/z/zbar/xmake.lua
Outdated
| add_extsources("brew::zbar") | ||
| end | ||
|
|
||
| add_configs("symbologies", {description = "Select symbologies to compile", default = {"ean","databar","code128","code93","code39","codabar","i25","qrcode","sqcode"}, type = "table"}) |
waruqi
reviewed
Oct 19, 2024
packages/z/zbar/port/xmake.lua
Outdated
|
|
||
| -- add options | ||
| option("symbologies") | ||
| -- set_default({"ean","databar","code128","code93","code39","codabar","i25","qrcode","sqcode"}) |
waruqi
reviewed
Oct 20, 2024
packages/z/zbar/port/xmake.lua
Outdated
| set_version(get_config("vers")) | ||
|
|
||
| set_configvar("PACKAGE_VERSION", get_config("vers")) | ||
| set_configvar("PACKAGE_STRING", "zbar " .. get_config("vers")) |
waruqi
reviewed
Oct 20, 2024
packages/z/zbar/port/config.h.in
Outdated
| #undef PACKAGE_URL | ||
|
|
||
| /* Define to the version of this package. */ | ||
| #undef PACKAGE_VERSION |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ZBar is an open-source software suite for reading barcodes from various sources, including webcams. Its original development stopped in 2012, and mchehab took the task of keeping it updated with the V4L2 API.
Configuration
ZBar uses autotools and includes various components such as Python bindings, video input, and GUI widgets. For simplicity and portability, it has been ported to xmake, however, only essential configuration options are translated.