updated unmarshaling logic

[maurafortino]

What's Included:

• update to the ItemToInternalWebhook logic
• RegistryV2 was being unmarshaled into RegistryV1 due to having a handful of the same field names
• Checking canonical_name in v2 as it's not in v1 and it is a required field for V2

[denopink]

maybe we can simplify this by using https://pkg.go.dev/encoding/json#Decoder.DisallowUnknownFields ?

[maurafortino]

maybe we can simplify this by using https://pkg.go.dev/encoding/json#Decoder.DisallowUnknownFields ?

@denopink

i thought about using decoder but then found this article: https://dev.to/taqkarim/you-might-not-be-using-json-decoder-correctly-in-golang-12mb

if you're okay with the approach that shows how the decoder should be used I can move forward with that solution.

[denopink]

maybe we can simplify this by using https://pkg.go.dev/encoding/json#Decoder.DisallowUnknownFields ?

@denopink

i thought about using decoder but then found this article: https://dev.to/taqkarim/you-might-not-be-using-json-decoder-correctly-in-golang-12mb

if you're okay with the approach that shows how the decoder should be used I can move forward with that solution.

@maurafortino I like that article but I think the context is bit different (we can chat about it further if you want me to expand on that). I think using DisallowUnknownFields will keep the code cleaner and simpler imo.

[denopink]

other than adding back the newline on line 89, lgtm!

note: we're going to come back to this at a later date.