Remove bascule #265
Open
Remove bascule #265
+245
−1,035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurafortino
added
the
needs discussion
denopink
reviewed
Nov 15, 2024
transport_test.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func initializeKey() jwk.Key { |
There was a problem hiding this comment.
To keep things consistent to our other repos, let's do the following 🙂
- the string jwk should be made int a constant
- have the tests themselves call
jwk.ParseKeyand verify the parser worked
denopink
requested changes
Nov 15, 2024
denopink
reviewed
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed bascule from the transport.go file
TODO: update tests in transport_test file;
Discussion: not sure if the bascule replacement code is the most efficient