change 400 to 401 for invalid creds #240
Conversation
| @@ -91,7 +91,7 @@ func (fd *frontDoor) handleMissingCredentials(response http.ResponseWriter, err | |||
|
|
|||
| func (fd *frontDoor) handleInvalidCredentials(response http.ResponseWriter, err *bascule.InvalidCredentialsError) { | |||
| response.Header().Set("Content-Type", "text/plain") | |||
| response.WriteHeader(http.StatusBadRequest) | |||
| response.WriteHeader(http.StatusUnauthorized) | |||
There was a problem hiding this comment.
That's handling credentials that were misformatted or unparseable. That's definitely a bad request, since authentication hasn't even been done.
There was a problem hiding this comment.
gotcha, I thought anything invalid (like misformatted and unparseable) regarding creds would be consider a 401.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/v1 #240 +/- ##
============================================
Coverage ? 0.00%
============================================
Files ? 10
Lines ? 272
Branches ? 0
============================================
Hits ? 0
Misses ? 272
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I thought anything invalid (like misformatted and unparseable) regarding creds would be consider a 401. |
No description provided.