Senderwrapper

[maurafortino]

What's Included:

• commented back in caduceus request handler in http.go to implement the handler
• updated senderwrapper to use uber/fx
• created fx module for senderwrapper
• removed modules and replaced them with provide functions based off of uber/fx best practices
• Kept OutboundSenderFactory to avoid passing mutexes, but simplified so there wasn't so much duplication from SenderConfig --> CaduceusSenderWrapper --> OutboundSenderFactory --> CadueceusOutboundSender
• updated functions for metrics of senderwrapper and outboundsender
• added a webhook stub for testing

[codecov]

Codecov Report

Attention: 164 lines in your changes are missing coverage. Please review.

Comparison is base (132c6c5) 19.86% compared to head (234c7de) 16.78%.
Report is 4 commits behind head on denopink/feat/rewrite.

Files	Patch %	Lines
senderWrapper.go	0.00%	82 Missing ⚠️
outboundSender.go	0.00%	43 Missing ⚠️
metrics.go	0.00%	24 Missing ⚠️
http.go	0.00%	10 Missing ⚠️
httpClient.go	0.00%	4 Missing ⚠️
routes.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                    Coverage Diff                    @@
##           denopink/feat/rewrite     #436      +/-   ##
=========================================================
- Coverage                  19.86%   16.78%   -3.08%     
=========================================================
  Files                         12       12              
  Lines                       1148     1233      +85     
=========================================================
- Hits                         228      207      -21     
- Misses                       908     1014     +106     
  Partials                      12       12              

Flag	Coverage Δ
unittests	16.78% <0.00%> (-3.08%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[guardrails]

⚠️ We detected 1 security issue in this pull request:

Insecure Network Communication (1)

Severity	Details	Docs
Medium	Title: Insecure SSL/TLS versions allowed caduceus/senderWrapper.go Line 140 in 234c7de TLSClientConfig: &tls.Config{InsecureSkipVerify: config.DisableClientHostnameValidation},	📚

More info on how to fix Insecure Network Communication in Go.

---

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

[denopink]

lgtm but I recommend (if we aren't already doing this) that we reconsider not using the preexisting design (e.g. CaduceusSenderWrapper and etc) and try simplifying the overall outbound sender design and the related support structs

[denopink]

nice!