Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to wrpcontext.GetMessage #310

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Oct 27, 2023

requires us to merge and release xmidt-org/wrp-go#142 & xmidt-org/candlelight#155 first

@denopink denopink marked this pull request as draft October 27, 2023 20:23
@denopink denopink self-assigned this Oct 27, 2023
@guardrails
Copy link

guardrails bot commented Oct 30, 2023

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@denopink denopink added the bug label Nov 9, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #310 (a0ec415) into main (34f3ea8) will not change coverage.
Report is 5 commits behind head on main.
The diff coverage is 25.00%.

@@           Coverage Diff           @@
##             main     #310   +/-   ##
=======================================
  Coverage   20.95%   20.95%           
=======================================
  Files           7        7           
  Lines         730      730           
=======================================
  Hits          153      153           
  Misses        575      575           
  Partials        2        2           
Flag Coverage Δ
unittests 20.95% <25.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
WRPHandler.go 83.67% <100.00%> (ø)
primaryHandler.go 0.00% <0.00%> (ø)

@denopink denopink marked this pull request as ready for review November 10, 2023 16:56
@denopink denopink merged commit 64a85b5 into main Nov 10, 2023
16 checks passed
@denopink denopink deleted the denopink/update/wrpcontext-GetMessage branch November 10, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant