Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with xmlsec 1.3.3 #280

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

ayakael
Copy link
Contributor

@ayakael ayakael commented Jan 14, 2024

Fixes #279

@ayakael ayakael changed the title Add compatability with xmlsec 1.3.3 Add compatibility with xmlsec 1.3.3 Jan 14, 2024
@deronnax
Copy link

deronnax commented Mar 1, 2024

@ayakael you linked to a codespace (which can't be accessed). Did you mean #253?

@deronnax
Copy link

deronnax commented Mar 1, 2024

for info, and unless I am wrong, #253 which you say you need, introduces another use of xmlSecCryptoAppKeyLoad (the one you commented) but you don't correct it in your PR. So if #253 get merged and then yours, the problem still happens

@ayakael
Copy link
Contributor Author

ayakael commented Mar 1, 2024

@deronnax This PR only adjusts the codebase as it is. I already alerted of this issue on #253 . Ideally, the author should update that, but if they don't and it is merged I can adjust this it in this PR.

@deronnax
Copy link

deronnax commented Mar 4, 2024

But in the first message of this PR, you say #253 is a requirement for this PR, so when this PR is merged, #253 will have been too, no?

@ayakael
Copy link
Contributor Author

ayakael commented Mar 11, 2024

But in the first message of this PR, you say #253 is a requirement for this PR, so when this PR is merged, #253 will have been too, no?

It doesn't actually require it. Sorry for the confusion. This PR can be merged as-is.

@ayakael ayakael mentioned this pull request Mar 11, 2024
@ayakael
Copy link
Contributor Author

ayakael commented Mar 11, 2024

I forget a few doc changes that I just pushed now

@deronnax
Copy link

@bgaifullin just merging this would fix the current compatibility issue with current libxml, thus fixing python-xmlsec for everyone, and turn the CI back to green. Would you please merge this?

@jimjag jimjag merged commit a4e135a into xmlsec:master Mar 12, 2024
1 of 31 checks passed
@kloczek
Copy link

kloczek commented Mar 25, 2024

Is it possible to release new version because this PR? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xmlsec 1.3.3 incompatability
4 participants