Check that our wheels are compatible with lxml wheels #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this one since it hasn't seen any recent activity. Feel free to reopen if it is actually useful to anyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new CI action that builds wheels, then tests the built wheels against the LXML wheels from PyPI for version 5.0. 5.1 and 5.2. This makes sure that our binary wheels are compatible with the lxml binary wheels.
This test showed that the wheels we are building are only compatible with
lxml>= 5.0. Older versions fail in this test, since they are build against older versions of libxml2.I made this a separate workflow, but these tests could also be incorporated into new step in the wheels.yml workflow.