Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Skeleton #5

Merged
merged 7 commits into from
Dec 6, 2023
Merged

Project Skeleton #5

merged 7 commits into from
Dec 6, 2023

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Dec 4, 2023

Added a project skeleton with stubs for resolveDid, and a skeleton for tests as well

closes #1

src/main.rs Outdated Show resolved Hide resolved
@insipx insipx marked this pull request as draft December 4, 2023 23:17
@insipx insipx marked this pull request as ready for review December 5, 2023 15:54
@insipx insipx requested a review from jac18281828 December 5, 2023 15:56
Copy link
Contributor

@jac18281828 jac18281828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @insipx this is a great start. We will set the bar for tests and documentation a bit higher once we have the business logic in there but for now I'd say let's go!

@@ -0,0 +1,13 @@
mod common;
Copy link
Contributor

@jac18281828 jac18281828 Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd avoid use of the term 'common' - it is by definition applicable to everything and therefore not a distinction. It is probably suitable to add the common init function at the test root. Actually in my mind this is one of those cases where duplication is not bad, so adding it to every test individually would be my preference.

Copy link
Contributor Author

@insipx insipx Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can name it something else, but it has to be in it's own module, otherwise the cargo test runner will try to run tests inside each time

Maybe 'integration_util' or something similiar? Things like server setup and teardown will live here, along with the logging I put in there for now

@insipx insipx merged commit 8d268b9 into main Dec 6, 2023
2 checks passed
@insipx insipx deleted the project-setup branch January 17, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial project setup: didethresolver
2 participants