-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project Skeleton #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! @insipx this is a great start. We will set the bar for tests and documentation a bit higher once we have the business logic in there but for now I'd say let's go!
tests/integration_test.rs
Outdated
@@ -0,0 +1,13 @@ | |||
mod common; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd avoid use of the term 'common' - it is by definition applicable to everything and therefore not a distinction. It is probably suitable to add the common init function at the test root. Actually in my mind this is one of those cases where duplication is not bad, so adding it to every test individually would be my preference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can name it something else, but it has to be in it's own module, otherwise the cargo test runner will try to run tests inside each time
Maybe 'integration_util' or something similiar? Things like server setup and teardown will live here, along with the logging I put in there for now
Added a project skeleton with stubs for resolveDid, and a skeleton for tests as well
closes #1