Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

51: use address for resolveDid parameter #52

Merged
merged 1 commit into from
Feb 15, 2024
Merged

51: use address for resolveDid parameter #52

merged 1 commit into from
Feb 15, 2024

Conversation

jac18281828
Copy link
Contributor

closes #51

renaming publicKey parameter to address

@jac18281828 jac18281828 self-assigned this Feb 15, 2024
@jac18281828
Copy link
Contributor Author

tested:

curl -H "Content-Type: application/json" -d '{"id":1, "jsonrpc":"2.0", "method":"did_resolveDid", "params": { "address":"0x6CE..."} }' http://localhost:8080
{"jsonrpc":"2.0","result":{"didDocumentMetadata":{"deactivated":false,"versionId":5281718,"updated":"2024-02-13T19:07:36Z"}...

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (05b7e66) 97.28% compared to head (c7f7452) 97.27%.

Files Patch % Lines
lib/src/resolver.rs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   97.28%   97.27%   -0.01%     
==========================================
  Files          13       13              
  Lines        2833     2826       -7     
==========================================
- Hits         2756     2749       -7     
  Misses         77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jac18281828 jac18281828 merged commit c7f7452 into main Feb 15, 2024
4 of 6 checks passed
@jac18281828 jac18281828 deleted the jac/address branch February 15, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Feature request: use address for parameter name in resolveDid
2 participants