chore: Improve <Socials /> Farcaster URL processing (coinbase#1688)

xmtp · Dec 3, 2024 · 49c4e59 · 49c4e59
1 parent bae7ec6
commit 49c4e59
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/identity/components/Socials.test.tsx b/src/identity/components/Socials.test.tsx
@@ -133,7 +133,7 @@ describe('Socials', () => {
     );
     expect(screen.getByTestId('ockSocials_Farcaster')).toHaveAttribute(
       'href',
-      'farcasteruser',
+      'https://warpcast.com/farcasteruser',
     );
     expect(screen.getByTestId('ockSocials_Website')).toHaveAttribute(
       'href',

diff --git a/src/identity/utils/getSocialPlatformDetails.test.tsx b/src/identity/utils/getSocialPlatformDetails.test.tsx
@@ -19,7 +19,7 @@ describe('PLATFORM_CONFIG', () => {
 
   it('should generate correct Farcaster URL', () => {
     const url = PLATFORM_CONFIG.farcaster.href('username');
-    expect(url).toBe('username');
+    expect(url).toBe('https://warpcast.com/username');
   });
 
   it('should return website URL as-is', () => {

diff --git a/src/identity/utils/getSocialPlatformDetails.tsx b/src/identity/utils/getSocialPlatformDetails.tsx
@@ -19,7 +19,10 @@ export const PLATFORM_CONFIG: Record<
     icon: githubSvg,
   },
   farcaster: {
-    href: (value) => value,
+    href: (value) => {
+      const username = value.split('/').pop();
+      return `https://warpcast.com/${username}`;
+    },
     icon: warpcastSvg,
   },
   website: {