feat: add SubscribeAssociationChanges #238
Open
+32
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
approved these changes
Jan 2, 2025
richardhuaaa
reviewed
Jan 3, 2025
| // Request to subscribe to association changes, triggered by Identity Updates | ||
| message SubscribeAssociationChangesRequest {} | ||
|
|
||
| message SubscribeAssociationChangesResponse { |
There was a problem hiding this comment.
Is there any world where this can just be a stream of identity updates, with the parsing of the stream done client-side? Would be simpler/more compatible with decentralization/requiring less server trust
There was a problem hiding this comment.
I'm hoping in a decentralized world we can create a subgraph that does that aggregation by reading events from the blockchain and running our code. Then we can slice and dice the data any way we want.
But for now, it's a big ask for clients to run libxmtp from whatever language/framework they are using and correctly store previous association states and apply updates.
richardhuaaa
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
Issues
xmtp/xmtp-node-go#410