Fail silently for messages that can't decrypt (#69)

* add api client with grpc kotlin * catch the exception in decryption and fail silently
xmtp · Apr 25, 2023 · cb42008 · cb42008
1 parent c00314a
commit cb42008
Showing 1 changed file with 16 additions and 5 deletions.
diff --git a/library/src/main/java/org/xmtp/android/library/Conversations.kt b/library/src/main/java/org/xmtp/android/library/Conversations.kt
@@ -1,5 +1,6 @@
 package org.xmtp.android.library
 
+import android.util.Log
 import kotlinx.coroutines.flow.Flow
 import kotlinx.coroutines.flow.flow
 import kotlinx.coroutines.runBlocking
@@ -23,13 +24,18 @@ import org.xmtp.android.library.messages.toSignedPublicKeyBundle
 import org.xmtp.android.library.messages.walletAddress
 import org.xmtp.proto.message.contents.Contact
 import org.xmtp.proto.message.contents.Invitation
+import java.lang.Exception
 import java.util.Date
 
 data class Conversations(
     var client: Client,
     var conversations: MutableList<Conversation> = mutableListOf(),
 ) {
 
+    companion object {
+        private const val TAG = "CONVERSATIONS"
+    }
+
     fun fromInvite(envelope: Envelope): Conversation {
         val sealedInvitation = Invitation.SealedInvitation.parseFrom(envelope.message)
         val unsealed = sealedInvitation.v1.getInvitation(viewer = client.keys)
@@ -171,11 +177,16 @@ data class Conversations(
                     topic = Topic.userIntro(client.address)
                 ).envelopesList
             }
-        val messages = envelopes.map { envelope ->
-            val message = MessageV1Builder.buildFromBytes(envelope.message.toByteArray())
-            // Attempt to decrypt, just to make sure we can
-            message.decrypt(client.privateKeyBundleV1)
-            message
+        val messages = envelopes.mapNotNull { envelope ->
+            try {
+                val message = MessageV1Builder.buildFromBytes(envelope.message.toByteArray())
+                // Attempt to decrypt, just to make sure we can
+                message.decrypt(client.privateKeyBundleV1)
+                message
+            } catch (e: Exception) {
+                Log.d(TAG, e.message.toString())
+                null
+            }
         }
         val seenPeers: MutableMap<String, Date> = mutableMapOf()
         for (message in messages) {