Start publishing AssociationChange events #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
neekolas
force-pushed
the
12-30-implement_subscriptions
branch
from
4231933 to
909ce38
Compare
neekolas
force-pushed
the
12-31-start_publishing_events
branch
from
8c36a8b to
8af3e83
Compare
nplasterer
approved these changes
Jan 2, 2025
Comment on lines
+207
to
+208
| [][]byte{}, // TODO: Handle installations added | ||
| [][]byte{}, // TODO: Handle installations revoked |
There was a problem hiding this comment.
What doesn't work without these pieces? Just that they aren't stored?
There was a problem hiding this comment.
No one is asking for a stream of all the installations added, but I started to stub it out so that we can at least choose to add it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added Waku relay publishing for identity association changes.
What changed?
PublishIdentityUpdateResulttype to track changes in addresses and installationsPublishIdentityUpdateto return detailed results about changesIdentityApi_SubscribeAssociationChangesServerHow to test?
TestPublishAssociationChangesWhy make this change?
To enable real-time notifications of identity association changes through the Waku network, allowing clients to stay synchronized with updates to account addresses and installations.
Issues
#410