Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning in Helm #22

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fix warning in Helm #22

merged 1 commit into from
Jan 8, 2025

Conversation

mkysel
Copy link
Collaborator

@mkysel mkysel commented Jan 7, 2025

Fix:

W0107 10:53:45.880709   72989 warnings.go:70] spec.template.spec.containers[0].env[11]: hides previous definition of "XMTPD_METRICS_ENABLE", which may be dropped when using apply
W0107 10:53:45.914361   72989 warnings.go:70] autopilot-default-resources-mutator:Autopilot updated Deployment default/xmtpd-api: defaulted unspecified 'cpu' resource for containers [xmtpd] (see http://g.co/gke/autopilot-defaults).
W0107 10:53:45.914435   72989 warnings.go:70] spec.template.spec.containers[0].env[10]: hides previous definition of "XMTPD_METRICS_ENABLE", which may be dropped when using apply

The cause was that we were hardcoding metrics and allowing the config to set them.

Metrics are used for the probes, so they should never be turned off by configuration

@mkysel mkysel requested a review from a team as a code owner January 7, 2025 20:45
@mkysel mkysel merged commit b239a42 into main Jan 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants