Add color picker widget #1953
Merged
Add color picker widget #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn’t #1945 the issue? |
|
I’d forbid text selection in the picker popup. It’s quite easy to cause the glitch while dragging the wheel:
|
|
this looks great 👏 👏 |
nkrkv
reviewed
Feb 6, 2020
|
Is there any chance to apply the picker to generic inputs? If not, please, extract the issue about that into a separate issue. |
|
The same about “Revert” mentioned in #1945 |
nkrkv
requested changes
Feb 6, 2020
brusherru
force-pushed
the
feat-color-picker
branch
from
3aa6cac to
30f029e
Compare
|
@nkrkv done! The issue mentioned in the PR description. |
packages/xod-client-electron/src/debugger/sendToSerialMiddleware.js
Outdated
Show resolved
Hide resolved
brusherru
force-pushed
the
feat-color-picker
branch
from
d8416dd to
b28bdb3
Compare
nkrkv
approved these changes
Feb 10, 2020
brusherru
force-pushed
the
feat-color-picker
branch
from
b28bdb3 to
aa33137
Compare
|
Merge? |
…ate reusable component
…orks with state and tweaks in simulation mode
…olorPicker widget in debug session
…n to optimize performance
… optimization and tweak throttling
…tn` -> `ColorPicker_toggleBtn`
…DE_UPDATE_PROPERTY` to unified `NODE_PROPERTY_UPDATED`
…dic inputs and avoid rendering a multiple ColorPickerWidgets at one time
brusherru
force-pushed
the
feat-color-picker
branch
from
4b78155 to
91213f2
Compare
evgenykochetkov
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It partially closes #1945
The rest of the issue and additional tweaks is described in the new issue: #1954