Enable permissive max-len and max-lines as warning
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think 2000 lines is too little. |
|
The point of this warning is to push people to split up larger files. Even you reach the limit, you can just disable it in the file, hopefully as an exception rather than a common occurrence. 2000-lines is already excessive to me, but it could be a start to verify any pushback. |
|
For the record, this is what a 3000-lines file looks like. In a world of modules, this file would not have any reason to exist. https://github.com/joshuacline/windick/blob/main/windick.cmd |
fregante
commented
Jul 28, 2024
Co-authored-by: Federico Brigante <[email protected]>
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 20, 2024
##### [v0.46.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.46.0) ##### New rules - [`@stylistic/indent-binary-ops`](https://eslint.style/rules/plus/indent-binary-ops) [`d91defd`](xojs/eslint-config-xo@d91defd) - [`@stylistic/function-paren-newline`](https://eslint.style/rules/js/function-paren-newline) [`fb5e204`](xojs/eslint-config-xo@fb5e204) - [`@stylistic/block-spacing`](https://eslint.style/rules/js/block-spacing) [`cb6b443`](xojs/eslint-config-xo@cb6b443) - [`@stylistic/multiline-ternary`](https://eslint.style/rules/js/multiline-ternary) [`3dea281`](xojs/eslint-config-xo@3dea281) ##### Breaking - Require Node.js 18.18 - Migrate to flat config and require ESLint 9 ([#86](xojs/eslint-config-xo#86)) [`ec210f2`](xojs/eslint-config-xo@ec210f2) - Migrate config: https://eslint.org/docs/latest/use/configure/migration-guide ##### Improvements - Migrate deprecated rules to [`@stylistic`](https://eslint.style) [`0f81063`](xojs/eslint-config-xo@0f81063) - Enable permissive `max-len` and `max-lines` as warning ([#84](xojs/eslint-config-xo#84)) [`e669d26`](xojs/eslint-config-xo@e669d26) - Revert "Add option to `no-extra-boolean-cast`" ([#87](xojs/eslint-config-xo#87)) [`f010b63`](xojs/eslint-config-xo@f010b63) - Add option to `no-extra-boolean-cast` [`a6dc171`](xojs/eslint-config-xo@a6dc171) ##### [v0.45.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.45.0) - Allow class fields with no blank lines between ([#85](xojs/eslint-config-xo#85)) [`6f2ff13`](xojs/eslint-config-xo@6f2ff13) ##### [v0.44.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.44.0) ##### Breaking - Require Node.js 18 [`f2060de`](xojs/eslint-config-xo@f2060de) ##### New rules - [`logical-assignment-operators`](https://eslint.org/docs/latest/rules/logical-assignment-operators) [`27049c1`](xojs/eslint-config-xo@27049c1) - [`prefer-object-has-own`](https://eslint.org/docs/latest/rules/prefer-object-has-own) [`288a3ca`](xojs/eslint-config-xo@288a3ca) - [`object-curly-newline`](https://eslint.org/docs/latest/rules/object-curly-newline) ([#83](xojs/eslint-config-xo#83)) [`3a5448b`](xojs/eslint-config-xo@3a5448b) ##### Improvements - Ban `atob` and `btoa` [`dfa969c`](xojs/eslint-config-xo@dfa969c) - Replace deprecated `no-new-object` rule [`7f8f92e`](xojs/eslint-config-xo@7f8f92e) - `no-unused-vars`: Allow ignoring variables by prefixing with underscore [`b31ab8a`](xojs/eslint-config-xo@b31ab8a)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 20, 2024
##### [v0.46.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.46.0) ##### New rules - [`@stylistic/indent-binary-ops`](https://eslint.style/rules/plus/indent-binary-ops) [`d91defd`](xojs/eslint-config-xo@d91defd) - [`@stylistic/function-paren-newline`](https://eslint.style/rules/js/function-paren-newline) [`fb5e204`](xojs/eslint-config-xo@fb5e204) - [`@stylistic/block-spacing`](https://eslint.style/rules/js/block-spacing) [`cb6b443`](xojs/eslint-config-xo@cb6b443) - [`@stylistic/multiline-ternary`](https://eslint.style/rules/js/multiline-ternary) [`3dea281`](xojs/eslint-config-xo@3dea281) ##### Breaking - Require Node.js 18.18 - Migrate to flat config and require ESLint 9 ([#86](xojs/eslint-config-xo#86)) [`ec210f2`](xojs/eslint-config-xo@ec210f2) - Migrate config: https://eslint.org/docs/latest/use/configure/migration-guide ##### Improvements - Migrate deprecated rules to [`@stylistic`](https://eslint.style) [`0f81063`](xojs/eslint-config-xo@0f81063) - Enable permissive `max-len` and `max-lines` as warning ([#84](xojs/eslint-config-xo#84)) [`e669d26`](xojs/eslint-config-xo@e669d26) - Revert "Add option to `no-extra-boolean-cast`" ([#87](xojs/eslint-config-xo#87)) [`f010b63`](xojs/eslint-config-xo@f010b63) - Add option to `no-extra-boolean-cast` [`a6dc171`](xojs/eslint-config-xo@a6dc171) ##### [v0.45.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.45.0) - Allow class fields with no blank lines between ([#85](xojs/eslint-config-xo#85)) [`6f2ff13`](xojs/eslint-config-xo@6f2ff13) ##### [v0.44.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.44.0) ##### Breaking - Require Node.js 18 [`f2060de`](xojs/eslint-config-xo@f2060de) ##### New rules - [`logical-assignment-operators`](https://eslint.org/docs/latest/rules/logical-assignment-operators) [`27049c1`](xojs/eslint-config-xo@27049c1) - [`prefer-object-has-own`](https://eslint.org/docs/latest/rules/prefer-object-has-own) [`288a3ca`](xojs/eslint-config-xo@288a3ca) - [`object-curly-newline`](https://eslint.org/docs/latest/rules/object-curly-newline) ([#83](xojs/eslint-config-xo#83)) [`3a5448b`](xojs/eslint-config-xo@3a5448b) ##### Improvements - Ban `atob` and `btoa` [`dfa969c`](xojs/eslint-config-xo@dfa969c) - Replace deprecated `no-new-object` rule [`7f8f92e`](xojs/eslint-config-xo@7f8f92e) - `no-unused-vars`: Allow ignoring variables by prefixing with underscore [`b31ab8a`](xojs/eslint-config-xo@b31ab8a)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 20, 2024
##### [v0.46.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.46.0) ##### New rules - [`@stylistic/indent-binary-ops`](https://eslint.style/rules/plus/indent-binary-ops) [`d91defd`](xojs/eslint-config-xo@d91defd) - [`@stylistic/function-paren-newline`](https://eslint.style/rules/js/function-paren-newline) [`fb5e204`](xojs/eslint-config-xo@fb5e204) - [`@stylistic/block-spacing`](https://eslint.style/rules/js/block-spacing) [`cb6b443`](xojs/eslint-config-xo@cb6b443) - [`@stylistic/multiline-ternary`](https://eslint.style/rules/js/multiline-ternary) [`3dea281`](xojs/eslint-config-xo@3dea281) ##### Breaking - Require Node.js 18.18 - Migrate to flat config and require ESLint 9 ([#86](xojs/eslint-config-xo#86)) [`ec210f2`](xojs/eslint-config-xo@ec210f2) - Migrate config: https://eslint.org/docs/latest/use/configure/migration-guide ##### Improvements - Migrate deprecated rules to [`@stylistic`](https://eslint.style) [`0f81063`](xojs/eslint-config-xo@0f81063) - Enable permissive `max-len` and `max-lines` as warning ([#84](xojs/eslint-config-xo#84)) [`e669d26`](xojs/eslint-config-xo@e669d26) - Revert "Add option to `no-extra-boolean-cast`" ([#87](xojs/eslint-config-xo#87)) [`f010b63`](xojs/eslint-config-xo@f010b63) - Add option to `no-extra-boolean-cast` [`a6dc171`](xojs/eslint-config-xo@a6dc171) ##### [v0.45.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.45.0) - Allow class fields with no blank lines between ([#85](xojs/eslint-config-xo#85)) [`6f2ff13`](xojs/eslint-config-xo@6f2ff13) ##### [v0.44.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.44.0) ##### Breaking - Require Node.js 18 [`f2060de`](xojs/eslint-config-xo@f2060de) ##### New rules - [`logical-assignment-operators`](https://eslint.org/docs/latest/rules/logical-assignment-operators) [`27049c1`](xojs/eslint-config-xo@27049c1) - [`prefer-object-has-own`](https://eslint.org/docs/latest/rules/prefer-object-has-own) [`288a3ca`](xojs/eslint-config-xo@288a3ca) - [`object-curly-newline`](https://eslint.org/docs/latest/rules/object-curly-newline) ([#83](xojs/eslint-config-xo#83)) [`3a5448b`](xojs/eslint-config-xo@3a5448b) ##### Improvements - Ban `atob` and `btoa` [`dfa969c`](xojs/eslint-config-xo@dfa969c) - Replace deprecated `no-new-object` rule [`7f8f92e`](xojs/eslint-config-xo@7f8f92e) - `no-unused-vars`: Allow ignoring variables by prefixing with underscore [`b31ab8a`](xojs/eslint-config-xo@b31ab8a)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 21, 2024
##### [v0.46.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.46.0) ##### New rules - [`@stylistic/indent-binary-ops`](https://eslint.style/rules/plus/indent-binary-ops) [`d91defd`](xojs/eslint-config-xo@d91defd) - [`@stylistic/function-paren-newline`](https://eslint.style/rules/js/function-paren-newline) [`fb5e204`](xojs/eslint-config-xo@fb5e204) - [`@stylistic/block-spacing`](https://eslint.style/rules/js/block-spacing) [`cb6b443`](xojs/eslint-config-xo@cb6b443) - [`@stylistic/multiline-ternary`](https://eslint.style/rules/js/multiline-ternary) [`3dea281`](xojs/eslint-config-xo@3dea281) ##### Breaking - Require Node.js 18.18 - Migrate to flat config and require ESLint 9 ([#86](xojs/eslint-config-xo#86)) [`ec210f2`](xojs/eslint-config-xo@ec210f2) - Migrate config: https://eslint.org/docs/latest/use/configure/migration-guide ##### Improvements - Migrate deprecated rules to [`@stylistic`](https://eslint.style) [`0f81063`](xojs/eslint-config-xo@0f81063) - Enable permissive `max-len` and `max-lines` as warning ([#84](xojs/eslint-config-xo#84)) [`e669d26`](xojs/eslint-config-xo@e669d26) - Revert "Add option to `no-extra-boolean-cast`" ([#87](xojs/eslint-config-xo#87)) [`f010b63`](xojs/eslint-config-xo@f010b63) - Add option to `no-extra-boolean-cast` [`a6dc171`](xojs/eslint-config-xo@a6dc171) ##### [v0.45.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.45.0) - Allow class fields with no blank lines between ([#85](xojs/eslint-config-xo#85)) [`6f2ff13`](xojs/eslint-config-xo@6f2ff13) ##### [v0.44.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.44.0) ##### Breaking - Require Node.js 18 [`f2060de`](xojs/eslint-config-xo@f2060de) ##### New rules - [`logical-assignment-operators`](https://eslint.org/docs/latest/rules/logical-assignment-operators) [`27049c1`](xojs/eslint-config-xo@27049c1) - [`prefer-object-has-own`](https://eslint.org/docs/latest/rules/prefer-object-has-own) [`288a3ca`](xojs/eslint-config-xo@288a3ca) - [`object-curly-newline`](https://eslint.org/docs/latest/rules/object-curly-newline) ([#83](xojs/eslint-config-xo#83)) [`3a5448b`](xojs/eslint-config-xo@3a5448b) ##### Improvements - Ban `atob` and `btoa` [`dfa969c`](xojs/eslint-config-xo@dfa969c) - Replace deprecated `no-new-object` rule [`7f8f92e`](xojs/eslint-config-xo@7f8f92e) - `no-unused-vars`: Allow ignoring variables by prefixing with underscore [`b31ab8a`](xojs/eslint-config-xo@b31ab8a)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 21, 2024
##### [v0.46.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.46.0) ##### New rules - [`@stylistic/indent-binary-ops`](https://eslint.style/rules/plus/indent-binary-ops) [`d91defd`](xojs/eslint-config-xo@d91defd) - [`@stylistic/function-paren-newline`](https://eslint.style/rules/js/function-paren-newline) [`fb5e204`](xojs/eslint-config-xo@fb5e204) - [`@stylistic/block-spacing`](https://eslint.style/rules/js/block-spacing) [`cb6b443`](xojs/eslint-config-xo@cb6b443) - [`@stylistic/multiline-ternary`](https://eslint.style/rules/js/multiline-ternary) [`3dea281`](xojs/eslint-config-xo@3dea281) ##### Breaking - Require Node.js 18.18 - Migrate to flat config and require ESLint 9 ([#86](xojs/eslint-config-xo#86)) [`ec210f2`](xojs/eslint-config-xo@ec210f2) - Migrate config: https://eslint.org/docs/latest/use/configure/migration-guide ##### Improvements - Migrate deprecated rules to [`@stylistic`](https://eslint.style) [`0f81063`](xojs/eslint-config-xo@0f81063) - Enable permissive `max-len` and `max-lines` as warning ([#84](xojs/eslint-config-xo#84)) [`e669d26`](xojs/eslint-config-xo@e669d26) - Revert "Add option to `no-extra-boolean-cast`" ([#87](xojs/eslint-config-xo#87)) [`f010b63`](xojs/eslint-config-xo@f010b63) - Add option to `no-extra-boolean-cast` [`a6dc171`](xojs/eslint-config-xo@a6dc171) ##### [v0.45.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.45.0) - Allow class fields with no blank lines between ([#85](xojs/eslint-config-xo#85)) [`6f2ff13`](xojs/eslint-config-xo@6f2ff13) ##### [v0.44.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.44.0) ##### Breaking - Require Node.js 18 [`f2060de`](xojs/eslint-config-xo@f2060de) ##### New rules - [`logical-assignment-operators`](https://eslint.org/docs/latest/rules/logical-assignment-operators) [`27049c1`](xojs/eslint-config-xo@27049c1) - [`prefer-object-has-own`](https://eslint.org/docs/latest/rules/prefer-object-has-own) [`288a3ca`](xojs/eslint-config-xo@288a3ca) - [`object-curly-newline`](https://eslint.org/docs/latest/rules/object-curly-newline) ([#83](xojs/eslint-config-xo#83)) [`3a5448b`](xojs/eslint-config-xo@3a5448b) ##### Improvements - Ban `atob` and `btoa` [`dfa969c`](xojs/eslint-config-xo@dfa969c) - Replace deprecated `no-new-object` rule [`7f8f92e`](xojs/eslint-config-xo@7f8f92e) - `no-unused-vars`: Allow ignoring variables by prefixing with underscore [`b31ab8a`](xojs/eslint-config-xo@b31ab8a)
renovate bot
added a commit
to mmkal/eslint-plugin-mmkal
that referenced
this pull request
Aug 21, 2024
##### [v0.46.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.46.0) ##### New rules - [`@stylistic/indent-binary-ops`](https://eslint.style/rules/plus/indent-binary-ops) [`d91defd`](xojs/eslint-config-xo@d91defd) - [`@stylistic/function-paren-newline`](https://eslint.style/rules/js/function-paren-newline) [`fb5e204`](xojs/eslint-config-xo@fb5e204) - [`@stylistic/block-spacing`](https://eslint.style/rules/js/block-spacing) [`cb6b443`](xojs/eslint-config-xo@cb6b443) - [`@stylistic/multiline-ternary`](https://eslint.style/rules/js/multiline-ternary) [`3dea281`](xojs/eslint-config-xo@3dea281) ##### Breaking - Require Node.js 18.18 - Migrate to flat config and require ESLint 9 ([#86](xojs/eslint-config-xo#86)) [`ec210f2`](xojs/eslint-config-xo@ec210f2) - Migrate config: https://eslint.org/docs/latest/use/configure/migration-guide ##### Improvements - Migrate deprecated rules to [`@stylistic`](https://eslint.style) [`0f81063`](xojs/eslint-config-xo@0f81063) - Enable permissive `max-len` and `max-lines` as warning ([#84](xojs/eslint-config-xo#84)) [`e669d26`](xojs/eslint-config-xo@e669d26) - Revert "Add option to `no-extra-boolean-cast`" ([#87](xojs/eslint-config-xo#87)) [`f010b63`](xojs/eslint-config-xo@f010b63) - Add option to `no-extra-boolean-cast` [`a6dc171`](xojs/eslint-config-xo@a6dc171) ##### [v0.45.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.45.0) - Allow class fields with no blank lines between ([#85](xojs/eslint-config-xo#85)) [`6f2ff13`](xojs/eslint-config-xo@6f2ff13) ##### [v0.44.0](https://github.com/xojs/eslint-config-xo/releases/tag/v0.44.0) ##### Breaking - Require Node.js 18 [`f2060de`](xojs/eslint-config-xo@f2060de) ##### New rules - [`logical-assignment-operators`](https://eslint.org/docs/latest/rules/logical-assignment-operators) [`27049c1`](xojs/eslint-config-xo@27049c1) - [`prefer-object-has-own`](https://eslint.org/docs/latest/rules/prefer-object-has-own) [`288a3ca`](xojs/eslint-config-xo@288a3ca) - [`object-curly-newline`](https://eslint.org/docs/latest/rules/object-curly-newline) ([#83](xojs/eslint-config-xo#83)) [`3a5448b`](xojs/eslint-config-xo@3a5448b) ##### Improvements - Ban `atob` and `btoa` [`dfa969c`](xojs/eslint-config-xo@dfa969c) - Replace deprecated `no-new-object` rule [`7f8f92e`](xojs/eslint-config-xo@7f8f92e) - `no-unused-vars`: Allow ignoring variables by prefixing with underscore [`b31ab8a`](xojs/eslint-config-xo@b31ab8a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it might make sense to enable them as warning to look at the pushback without creating too much trouble.
I think 200ch is a good upper limit, but I'm not sure about "1000 lines", especially in files with inline documentation and licensing.
https://eslint.org/docs/v8.x/rules/max-lines
https://eslint.org/docs/v8.x/rules/max-len