Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v8 to the ignorePattern for capitalized-comments #88

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

Primajin
Copy link
Contributor

@Primajin Primajin commented Aug 5, 2024

closes: xojs/xo#765

V8 is Google's JS engine and allows for native code coverage. But in order to ignore lines from being gathered the string must be lowercase.

- /* V8 ignore next 3 */ <--- as the default capitalized-comments rule would change
+ /* v8 ignore next 3 */

Source: https://vitest.dev/guide/coverage.html#ignoring-code
Further context: https://eslint.org/docs/latest/rules/capitalized-comments

V8 is Google's JS engine and allows for native code coverage. But in order to ignore lines from being gathered the string must be lowercase https://vitest.dev/guide/coverage.html#ignoring-code
@sindresorhus sindresorhus merged commit 4bb2399 into xojs:main Aug 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[eslint-config-xo] - Allow v8 alongside c8 in capitalized-comments
2 participants