-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Skeleton #159
Open
rushi
wants to merge
22
commits into
xola:master
Choose a base branch
from
rushi:skeleton-upgrade
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Better Skeleton #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to easily create Skeletons quickly
Notes.
|
* 'master' of github.com:xola/ui-kit: (21 commits) Refactor announcements (left) & notices (right) drawer code (xola#177) 2.0.0-77 X2-2261: Sidebar drawer changes (xola#144) Move className towards the end 2.0.0-76 xola#148 Add Sidebar.Separator to show Global Settings (xola#158) Optimize imports 2.0.0-75 Upgrade important packages - Tailwind, Vite, Prettier (xola#160) Update README.md 2.0.0-74 X2-2345: Increased default line-height for alert children (xola#165) X2-2706: updated margin for custom content div (xola#164) 2.0.0-73 Update top padding Apply button for Date Ranger Picker (xola#162) X2-1553 Don't update input till user applies changes X2-1553 Have an apply button for date picker X2-1553 Add padding for the date picker popover only X2-1553 Fix relate date range picker layout ...
* 'master' of github.com:xola/ui-kit: Flash Upgrades (xola#180) Update README 2.0.0-82 2.0.0-81 Add nowrap for payment breakdown amounts (xola#182) 2.0.0-81 New Icons (xola#181) xola#149 Fix Inline Popover Styles (xola#170) Upgrade to Storybook 6.5.x (xola#175) Update story 2.0.0-80 Fix warnings due to invalid properties 2.0.0-79 X2-3007 Dashboard > Delete timeslots created on the fly (xola#179) Added few props for Photo Upload specific features (xola#161)
* 'master' of github.com:xola/ui-kit: X2-1898 (Scheduled Reports): Changes for exporting RelativeDateRange component, handling date picker calendar icon not being shown (xola#166)
* 'master' of github.com:xola/ui-kit: (24 commits) Add chromatic build skip name Add missing chromatic github action Add chromatic integration to test with things `npm audit fix` 2.0.0-94 X2-3511: Add class to datepicker input (xola#190) 2.0.0-93 Custom Logo in sidebar (xola#197) 2.0.0-92 Update logo on login screen Logo update (xola#196) Add "Xola Logos" story to show our various logos (xola#195) 2.0.0-91 Set `text-black` as default and update default base styles (xola#193) 2.0.0-90 Allow custom image url on login screen for internal tools (xola#189) Update currency symbol display + Story for currency (xola#191) 2.0.0-89 X2-3850: Added error field for inline value popover (xola#188) 2.0.0-88 ...
…ton-upgrade * 'skeleton-upgrade' of github.com:rushi/ui-kit:
* 'master' of github.com:xola/ui-kit: Remote `pull_request` target in favor of `pull_request_target` in chromatic action
* 'master' of github.com:xola/ui-kit: Fix down the prices so it doesnt show up broken on diffs
* 'master' of github.com:xola/ui-kit: ES Lint installation fix + Lint code fixes (xola#200) Fix action Add ESLint annotate action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #150 Best to pull locally and take a look
Seller app PR: https://github.com/xola/x2-seller/pull/1169