Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X2-6630: The date does not automatically change when you switch the booking from public to private (different schedules) if you add more than 1 demographic #252

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

khomyakov
Copy link
Contributor

Removed onChange handler from click outside as it casuses side-effects on the CreatePurchase flow and no longer needed as theres no Apply Button

…s on the CreatePurchase flow and no longer needed as theres no Apply Button
@@ -42,8 +42,6 @@ export const DatePickerPopover = ({
};

const handleClickOutside = () => {
// Revert back to the original value because the user didn't apply the changes
onChange(originalValue);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed onChange handler from click outside as it casuses side-effects on the CreatePurchase flow and no longer needed as theres no Apply Button

@manojx031 manojx031 merged commit fe1fda2 into xola:master Aug 22, 2023
4 checks passed
rushi added a commit to rushi/ui-kit that referenced this pull request Aug 22, 2023
* 'master' of github.com:xola/ui-kit:
  2.1.13
  X2-6630: The date does not automatically change when you switch the booking from public to private (different schedules) if you add more than 1 demographic (xola#252)
  2.1.12
  X2-5999 Show "--" if line item is per outing demographic (xola#251)
rushi added a commit to rushi/ui-kit that referenced this pull request Aug 27, 2023
…er' of github.com:xola/ui-kit into upgrade-forms

* 'upgrade-forms' of github.com:rushi/ui-kit:

* 'master' of github.com:xola/ui-kit:
  2.1.13
  X2-6630: The date does not automatically change when you switch the booking from public to private (different schedules) if you add more than 1 demographic (xola#252)
  2.1.12
  X2-5999 Show "--" if line item is per outing demographic (xola#251)
  2.1.11
  X2-6097 Remove Guest workflow enhancements (xola#244)
  2.1.10
  X2-6496 fix(datepicker-popover): resolves issue of date resetting to initial value when clicking outside of popover (xola#247)
  2.1.9
  X2-6098: Pull up roster from Purchase item (xola#248)
  2.1.8
  X2-5712 add break down for long word in breakdown item (xola#240)
  2.1.7
  X2-1192: submit button success animation (xola#230)
rushi added a commit to rushi/ui-kit that referenced this pull request Sep 4, 2023
* 'master' of github.com:xola/ui-kit:
  npm audit fix
  2.1.13
  X2-6630: The date does not automatically change when you switch the booking from public to private (different schedules) if you add more than 1 demographic (xola#252)
  2.1.12
  X2-5999 Show "--" if line item is per outing demographic (xola#251)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants