-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added accordion component to ui kit #293
Open
cddharthsingh-x
wants to merge
10
commits into
xola:master
Choose a base branch
from
cddharthsingh-x:accordion
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c503473
Added accordion component to ui kit
cddharthsingh-x 85af630
Merge branch 'xola:master' into accordion
cddharthsingh-x ded38d5
Lint fix
cddharthsingh-x c612757
Merge branch 'accordion' of github.com:cddharthsingh-x/ui-kit into ac…
cddharthsingh-x e473e5f
Stories for accordion
cddharthsingh-x f824f47
Merge branch 'master' into accordion
cddharthsingh-x 2c21bc4
Merge branch 'master' into accordion
cddharthsingh-x 3f5c33c
Merge branch 'master' into accordion
rushi 05e1357
Merge branch 'master' into accordion
rushi 1919110
Merge branch 'master' into accordion
rushi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
import { Disclosure } from "@headlessui/react"; | ||
import clsx from "clsx"; | ||
import React, { Children } from "react"; | ||
import { SlideDown } from "../Animation/SlideDown"; | ||
import { ChevronRightIcon } from "../../icons/ChevronRightIcon"; | ||
|
||
export const Accordion = ({ children }) => { | ||
const childrenArray = Children.toArray(children); | ||
return ( | ||
<div> | ||
<Disclosure> | ||
{({ open }) => ( | ||
<> | ||
<Disclosure.Button className="flex items-center"> | ||
<div className="mr-2" data-testid="accordion-dropdown-icon"> | ||
<ChevronRightIcon className={clsx(open && "rotate-90")} /> | ||
</div> | ||
|
||
{childrenArray.filter((child) => child?.type === Header)} | ||
</Disclosure.Button> | ||
|
||
<SlideDown isOpen={open}>{childrenArray.filter((child) => child?.type === Body)}</SlideDown> | ||
</> | ||
)} | ||
</Disclosure> | ||
</div> | ||
); | ||
}; | ||
|
||
const Header = ({ className, children, ...rest }) => { | ||
return ( | ||
<div className={clsx("flex items-center space-x-3", className)} {...rest}> | ||
{children} | ||
</div> | ||
); | ||
}; | ||
|
||
Accordion.Header = Header; | ||
|
||
const Body = ({ className, children, ...rest }) => { | ||
return ( | ||
<Disclosure.Panel as="div" className={clsx("p-2 pb-10", className)} {...rest}> | ||
{children} | ||
</Disclosure.Panel> | ||
); | ||
}; | ||
|
||
Accordion.Body = Body; | ||
rushi marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclosure
itself should have adiv
. Remove this div if you don't need it. Simplifies the markup, and if the end-user (seller app, admin etc) need an extra div, they can add itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed