X2-8266 | Cannot Decline Reservation through the Notifications Tab #295
Conversation
VitalyDevico
force-pushed
the
X2-8266
branch
from
14bc36d
to
c7b26d3
Compare
src/components/Sidebar/Sidebar.jsx
Outdated
| if (shouldCloseOnRouteChange && location?.search?.includes("redirect=true")) { | ||
| setIsLeftDrawerOpen(false); | ||
| setIsRightDrawerOpen(false); | ||
| } | ||
| }, [location.search, shouldCloseOnRouteChange]); |
There was a problem hiding this comment.
I think its better to close the drawer from x2-seller app. since this ui-kit component might be used across different apps. can you try to trigger the close event, when we click on decline / accept purchase
Also, to prevent closing this drawer on notifications changes, we can pass additional props shouldCloseOnChanges - pass this as false from x2-seller app.
@rushi can you also review this once
There was a problem hiding this comment.
done, could you please take another look
also, since we are preventing closing on notification changes, we need to manually close it after opening the purchase, to handle the case which was fixed by adding close-on-change logic previously (when we open a purchase from the purchases page), this logic added as part of the x2-seller PR https://github.com/xola/x2-seller/pull/3773
| isRightDrawerVisible = null, | ||
| setIsRightDrawerVisible, |
There was a problem hiding this comment.
Why do you need these two? There's too many props coming in.
There was a problem hiding this comment.
in order to trigger closing of drawer from the seller app as proposed in comment above
There was a problem hiding this comment.
I was thinking on other way to fixing this via url params, maybe you have some suggestions how to optimize? in the end we need to handle case when the api call is made on the background and not close the drawer, but another case when we need to close it when purchase tile clicked while the user on the /purchases route
No description provided.