X2-8421 | fix: call drawer.onClose when drawer is closed #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitalyDevico
commented
Jan 8, 2024
| @@ -60,18 +60,14 @@ export const Sidebar = ({ | |||
| const hideRightDrawer = rightDrawer?.count <= 0 || !rightDrawer; | |||
|
|
|||
| const handleOnClose = (direction, closeDrawer) => { | |||
| if (direction === "left") { | |||
| if (closeDrawer) { | |||
| if (closeDrawer) { | |||
There was a problem hiding this comment.
call the .onClose method only on actual drawer close (e.g. avoid calling when click inside filter popover which cause unexpected closes when filtering), also refactored if clauses according to the linter to avoid lonely if inside else block
VitalyDevico
commented
Jan 8, 2024
| @@ -53,25 +57,25 @@ export const Sidebar = ({ | |||
| setIsLeftDrawerOpen(false); | |||
| } | |||
|
|
|||
| if (isRightDrawerOpen) { | |||
| rightDrawer.onClose?.(); | |||
There was a problem hiding this comment.
handle case when drawer closed via counter toggle
manojx031
approved these changes
Jan 9, 2024
|
Closing this one since all notification-related fixes will be handled in the same PR due to overlapping code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.