Encoding dataarrays #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that dataarrays are encoded as well to hopefully solve IndexError issues when datetimes are not coordinates. Works on #59
Added a custom OpenDAP protocol Array class that can encode multiple dims. Additionally added some additional tests and test data from various problematic datasets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to make sure that dataarrays are encoded as well to hopefully solve IndexError issues when datetimes are not coordinates, as well as standardizing encoding to consolidate that logic.
It additionally adds a new class of OpenDAP Array that can support encoding multiple dimensions for non-coordinate dimensions.
I've added some of the various problematic test datasets (and set up tests for them) from:
IndexErrorfor .dods for certain datasets #59We can use the same structure to add additional minimal problematic datasets.
I've additionally added a Docker Compose file and instructions on how to launch a Hyrax OpenDAP server and a man in the middle proxy to compare traffic to see differences between responses better.
Works on #59