Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #553 #554

Merged
merged 13 commits into from
Feb 14, 2025
Merged

Fix issue #553 #554

merged 13 commits into from
Feb 14, 2025

Conversation

maurov
Copy link
Member

@maurov maurov commented Feb 11, 2025

This fixes #553 and adds basic tests

@maurov maurov requested a review from newville February 11, 2025 11:54
@maurov maurov added this to the 2025.2.x milestone Feb 11, 2025
@maurov
Copy link
Member Author

maurov commented Feb 11, 2025

@newville the tests fail on Ubuntu. I have tried modifying the CI workflow recipe by including the DISPLAY environmental variable, but still fail. Do you have an idea how to fix it?

@newville
Copy link
Member

@maurov I think the CI ubuntu virtual machines won't allow a DISPLAY to run. It's a common problem for GUI testing.

Maybe we can make a folder specifically for GUI tests that aren't run by the CI but make it easy for us to "run all the GUI tests".

@maurov
Copy link
Member Author

maurov commented Feb 11, 2025

@newville using pytest-xvfb permits correctly passing the GUI tests on Ubuntu.

There is still an error on Windows with python 3.9 that I do not understand. Do you have any suggestion?

@newville
Copy link
Member

@maurov Hm, the failure for Windows and Python 3.9 seems to be something from pymatgen. I'm not sure I fully understand the error message.

@newville
Copy link
Member

@maurov I would simply not run the test on Windows.

if os.name == 'nt':
    raise pytest.skip('skip GUI testing on Windows')

@maurov
Copy link
Member Author

maurov commented Feb 13, 2025

@newville I have skipped one failing test on Windows and python 3.9. Now everything looks fine and may be merged.

@newville
Copy link
Member

@maurov OK, great, thanks!

@newville newville merged commit 1e098ec into xraypy:master Feb 14, 2025
8 checks passed
@maurov maurov deleted the fix553 branch February 19, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

running feff from structure or feff.inp file not doing anything
2 participants