-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #553 #554
Fix issue #553 #554
Conversation
@newville the tests fail on Ubuntu. I have tried modifying the CI workflow recipe by including the |
@maurov I think the CI ubuntu virtual machines won't allow a DISPLAY to run. It's a common problem for GUI testing. Maybe we can make a folder specifically for GUI tests that aren't run by the CI but make it easy for us to "run all the GUI tests". |
@newville using There is still an error on Windows with python 3.9 that I do not understand. Do you have any suggestion? |
@maurov Hm, the failure for Windows and Python 3.9 seems to be something from pymatgen. I'm not sure I fully understand the error message. |
@maurov I would simply not run the test on Windows.
|
@newville I have skipped one failing test on Windows and python 3.9. Now everything looks fine and may be merged. |
@maurov OK, great, thanks! |
This fixes #553 and adds basic tests