-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes missing dependencies in the build #78
base: master
Are you sure you want to change the base?
Conversation
…unused dependencies
ca4089c
to
63a0a22
Compare
63a0a22
to
8dca45a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions about added dependencies...
@@ -79,12 +79,27 @@ | |||
<artifactId>xmlresolver</artifactId> | |||
<version>4.5.1</version> | |||
</dependency> | |||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you add this dependency ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because according to running mvn dependency:analyze-only
it is in use in the code base, which I suspect is correct ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is.
but org.eclipse.sisu:org.eclipse.sisu.plexus
is included by org.apache.maven:maven-plugin-api
and by org.apache.maven:maven-core
, and I have dependencies declared on this ones. So why do you add a direct declaration to this dependency, which is transitively included ? To explicitely declare that I use this dependency ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure... Transitive dependencies are very tricky. But I tend to find it you make the dependency plugin happy then you usually have less problems. Feel free to adjust my PR if you prefer; you should be able to push commits to my branch if you want to make some changes.
<dependency> | ||
<groupId>junit</groupId> | ||
<artifactId>junit</artifactId> | ||
<version>4.13.1</version> | ||
<scope>test</scope> | ||
</dependency> | ||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this one ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used in the code base here: https://github.com/xspec/xspec-maven-plugin-1/blob/master/src/main/java/io/xspec/maven/xspecMavenPlugin/utils/CatalogWriter.java#L88
Closes #73