Fixes missing dependencies in the build #78
Conversation
…unused dependencies
adamretter
force-pushed
the
hotfix/dependencies
branch
from
ca4089c
to
63a0a22
Compare
adamretter
force-pushed
the
hotfix/dependencies
branch
from
63a0a22
to
8dca45a
Compare
| @@ -79,12 +79,27 @@ | |||
| <artifactId>xmlresolver</artifactId> | |||
| <version>4.5.1</version> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
Why did you add this dependency ?
There was a problem hiding this comment.
Because according to running mvn dependency:analyze-only it is in use in the code base, which I suspect is correct ;-)
There was a problem hiding this comment.
It is.
but org.eclipse.sisu:org.eclipse.sisu.plexus is included by org.apache.maven:maven-plugin-api and by org.apache.maven:maven-core, and I have dependencies declared on this ones. So why do you add a direct declaration to this dependency, which is transitively included ? To explicitely declare that I use this dependency ?
There was a problem hiding this comment.
I'm not entirely sure... Transitive dependencies are very tricky. But I tend to find it you make the dependency plugin happy then you usually have less problems. Feel free to adjust my PR if you prefer; you should be able to push commits to my branch if you want to make some changes.
| <dependency> | ||
| <groupId>junit</groupId> | ||
| <artifactId>junit</artifactId> | ||
| <version>4.13.1</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
It is used in the code base here: https://github.com/xspec/xspec-maven-plugin-1/blob/master/src/main/java/io/xspec/maven/xspecMavenPlugin/utils/CatalogWriter.java#L88
Closes #73