Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xvariable_masked_view should inherit from xvariable_base #193

Merged
merged 1 commit into from
Jan 21, 2019
Merged

xvariable_masked_view should inherit from xvariable_base #193

merged 1 commit into from
Jan 21, 2019

Conversation

martinRenou
Copy link
Member

No description provided.

@martinRenou martinRenou changed the title WIP - xmasked_view should inherit from xvariable_base xmasked_view should inherit from xvariable_base Jan 18, 2019
@martinRenou
Copy link
Member Author

Not only it removes a lot of code, but it also helped me to found a bug in the select_outer! When selecting a value which is not in the boundaries, I was returning a masked_value instead of a missing_value

JohanMabille
JohanMabille requested changes Jan 21, 2019
View reviewed changes
include/xframe/xselecting.hpp Outdated Show resolved Hide resolved
@martinRenou martinRenou changed the title xmasked_view should inherit from xvariable_base xvariable_masked_view should inherit from xvariable_base Jan 21, 2019
@JohanMabille JohanMabille merged commit 4af1446 into xtensor-stack:master Jan 21, 2019
@martinRenou martinRenou deleted the xmasked_view_variable_base branch January 21, 2019 18:37
@martinRenou martinRenou mentioned this pull request Jan 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinRenou @JohanMabille