Minimalistic fast math support #551
Conversation
serge-sans-paille
force-pushed
the
feature/fast-math-support
branch
from
c1d20d4
to
ffaec96
Compare
serge-sans-paille
force-pushed
the
feature/fast-math-support
branch
from
b20a6ea
to
66e950d
Compare
|
Does this actually enable the testing? |
|
No, I gave up with testing under |
serge-sans-paille
changed the title
JohanMabille
force-pushed
the
master
branch
3 times, most recently
from
6c6dc1f
to
52984ef
Compare
|
As with the other fix based on volatile, my opinion, independently of it works or not here and now, is that I don't know how prone is to silently breaking in future versions of any compiler. For me to introduce a fix like this I'd have to be sure to know why it works now and why it didn't before, which means to do some reading of the C++ standard (a boring chore). This doesn't mean that the code is incorrect. Just that I see it as risky code because I don't really know why this is good and the other version was bad. If this would my codebase, I'd probably explain what is going on with the reorderings either as a comment on the code or on the commit message body. |
No description provided.