make linter happy

.eslintrc.json

@@ -11,6 +11,7 @@
       "src/browser/tsconfig.json",
       "src/common/tsconfig.json",
       "src/headless/tsconfig.json",
+      "src/shared/tsconfig.json",
       "src/vs/tsconfig.json",
       "test/benchmark/tsconfig.json",
       "test/playwright/tsconfig.json",

addons/addon-progress/src/ProgressAddon.ts

@@ -7,8 +7,10 @@ import { Terminal, ITerminalAddon, IDisposable, EmitterCtorType, IEmitter, IEven
 import type { ProgressAddon as IProgressApi, IProgressState } from '@xterm/addon-progress';
 
 // to use impl parts:
+
 // in 3rd party addons
-//import { EmitterAddon } from '@xterm/xterm';
+// import { EmitterAddon } from '@xterm/xterm';
+
 // in xtermjs repo addons
 import { EmitterAddon } from 'shared/shared';
 
@@ -45,9 +47,9 @@ export class ProgressAddon extends EmitterAddon implements ITerminalAddon, IProg
   private _onChange: IEmitter<IProgressState>;
   public onChange: IEvent<IProgressState>;
 
-  constructor(protected readonly emitterCtor: EmitterCtorType) {
-    super(emitterCtor);
-    this._onChange = new this.emitterCtor<IProgressState>();
+  constructor(protected readonly _emitterCtor: EmitterCtorType) {
+    super(_emitterCtor);
+    this._onChange = new this._emitterCtor<IProgressState>();
     this.onChange = this._onChange.event;
   }
 

addons/addon-progress/typings/addon-progress.d.ts

@@ -16,7 +16,7 @@ declare module '@xterm/addon-progress' {
     /**
      * Creates a new progress addon
      */
-    constructor(emitterCtor: EmitterCtorType);
+    constructor(_emitterCtor: EmitterCtorType);
 
     /**
      * Activates the addon

src/browser/public/Terminal.ts

@@ -6,14 +6,14 @@
 import * as Strings from 'browser/LocalizableStrings';
 import { CoreBrowserTerminal as TerminalCore } from 'browser/CoreBrowserTerminal';
 import { IBufferRange, ITerminal } from 'browser/Types';
-import { Disposable, DisposableStore, toDisposable as toDisposableOrig } from 'vs/base/common/lifecycle';
+import { Disposable } from 'vs/base/common/lifecycle';
 import { ITerminalOptions } from 'common/Types';
 import { AddonManager } from 'common/public/AddonManager';
 import { BufferNamespaceApi } from 'common/public/BufferNamespaceApi';
 import { ParserApi } from 'common/public/ParserApi';
 import { UnicodeApi } from 'common/public/UnicodeApi';
 import { IBufferNamespace as IBufferNamespaceApi, IDecoration, IDecorationOptions, IDisposable, ILinkProvider, ILocalizableStrings, IMarker, IModes, IParser, ITerminalAddon, Terminal as ITerminalApi, ITerminalInitOnlyOptions, IUnicodeHandling } from '@xterm/xterm';
-import { Emitter, type Event } from 'vs/base/common/event';
+import { type Event } from 'vs/base/common/event';
 
 /**
  * The set of options that only have an effect when set in the Terminal constructor.

src/shared/shared.ts

@@ -15,15 +15,15 @@ export class DisposableAddon implements IDisposable {
     this._store = new storeCtor();
   }
 
-  dispose(): void {
+  public dispose(): void {
     this._store.dispose();
   }
 }
 
 
 export class EmitterAddon {
   constructor(
-    protected readonly emitterCtor: EmitterCtorType
+    protected readonly _emitterCtor: EmitterCtorType
   ) {}
 }
 
@@ -33,12 +33,12 @@ export class DisposableEmitterAddon implements IDisposable {
 
   constructor(
     readonly storeCtor: DisposableStoreCtorType,
-    protected readonly emitterCtor: EmitterCtorType
+    protected readonly _emitterCtor: EmitterCtorType
   ) {
     this._store = new storeCtor();
   }
 
-  dispose(): void {
+  public dispose(): void {
     this._store.dispose();
   }
 }

typings/xterm.d.ts

@@ -2011,16 +2011,16 @@ declare module '@xterm/xterm' {
   export class DisposableAddon implements IDisposable {
     protected readonly _store: IDisposableStore;
     constructor(storeCtor: DisposableStoreCtorType);
-    dispose(): void;
+    public dispose(): void;
   }
   export class EmitterAddon {
-    protected readonly emitterCtor: EmitterCtorType;
-    constructor(emitterCtor: EmitterCtorType);
+    protected readonly _emitterCtor: EmitterCtorType;
+    constructor(_emitterCtor: EmitterCtorType);
   }
   export class DisposableEmitterAddon implements IDisposable {
     protected readonly _store: IDisposableStore;
-    protected readonly emitterCtor: EmitterCtorType;
-    constructor(storeCtor: DisposableStoreCtorType, emitterCtor: EmitterCtorType);
-    dispose(): void;
+    protected readonly _emitterCtor: EmitterCtorType;
+    constructor(storeCtor: DisposableStoreCtorType, _emitterCtor: EmitterCtorType);
+    public dispose(): void;
   }
 }