update codenarc, pmd, spotbugs, checkstyle;

add checkstyle rule NoWhitespaceBeforeCaseDefaultColon;
disable EI_EXPOSE_REP and EI_EXPOSE_REP2 spotbugs checks

CHANGELOG.md

@@ -4,8 +4,19 @@
 * Add spotbugsShowStackTraces option with default to false.
     Option introduced to change the default for spotbug's showStackTraces option
     to avoid additional stacktrace in logs in non-strict mode (when plugin not fails on errors)
+* Update spotbugs 4.2.3 -> 4.4.2
+* Update spotbugs exclusions:
+    - Exclude [EI_EXPOSE_REP](https://spotbugs.readthedocs.io/en/latest/bugDescriptions.html#ei-may-expose-internal-representation-by-returning-reference-to-mutable-object-ei-expose-rep)
+      due to confusing false positives
+    - Exclude [EI_EXPOSE_REP2](https://spotbugs.readthedocs.io/en/latest/bugDescriptions.html#ei2-may-expose-internal-representation-by-incorporating-reference-to-mutable-object-ei-expose-rep2)
+      due to confusing false positives
+* Update codenarc 2.1.0 -> 2.2.0
+* Update pmd 6.34 -> 6.40 (java 17 support)
 * Deprecate quality.pmdIncremental property because incremental analysis is enabled by default
     since gradle 6.4 (property only useful for enabling it in gradle 5.6 - 6.3)
+* Update checkstyle 8.42 -> 9.1
+* Update checkstyle config:
+  - Add [NoWhitespaceBeforeCaseDefaultColon](https://checkstyle.sourceforge.io/config_whitespace.html#NoWhitespaceBeforeCaseDefaultColon)
 
 ### 4.6.0 (2021-05-01)
 * Fix gradle 7 compatibility (for checkstyle plugin)

build.gradle

@@ -53,10 +53,10 @@ mkdocs {
     }
     extras = [
             'version': project.docVersion,
-            'checkstyle': '8.42',
-            'pmd': '6.34.0',
-            'spotbugs': '4.2.3',
-            'codenarc': '2.1.0',
+            'checkstyle': '9.1',
+            'pmd': '6.40.0',
+            'spotbugs': '4.4.2',
+            'codenarc': '2.2.0',
             'spotbugsPlugin': project.spotbugsPluginVersion,
             'cpd': project.cpdVersion,
             'animalsnifferPlugin': project.animalsnifferVersion,

src/main/groovy/ru/vyarus/gradle/plugin/quality/QualityExtension.groovy

@@ -21,10 +21,10 @@ class QualityExtension {
         sourceSets = [project.sourceSets.main] as Collection<SourceSet>
     }
 
-    String checkstyleVersion = '8.42'
+    String checkstyleVersion = '9.1'
     String pmdVersion = '6.34.0'
-    String spotbugsVersion = '4.2.3'
-    String codenarcVersion = '2.1.0'
+    String spotbugsVersion = '4.4.2'
+    String codenarcVersion = '2.2.0'
 
     /**
      * Sets AnimalSniffer version.

src/main/resources/ru/vyarus/quality/config/checkstyle/checkstyle.xml

@@ -261,6 +261,7 @@
         <module name="NoLineWrap"/>
         <module name="NoWhitespaceAfter"/>
         <module name="NoWhitespaceBefore"/>
+        <module name="NoWhitespaceBeforeCaseDefaultColon"/>
         <module name="OperatorWrap"/>
         <module name="ParenPad"/>
         <module name="SeparatorWrap">

src/main/resources/ru/vyarus/quality/config/spotbugs/exclude.xml

@@ -19,6 +19,17 @@
         <!-- Disabled as confusing check (very misleading description) and also not so useful -->
         <Bug pattern="NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE"/>
     </Match>
+    <Match>
+        <!-- Disabled as confusing check (very misleading description) and also not so useful -->
+        <Bug pattern="NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE"/>
+    </Match>
+    <Match>
+        <!-- Disabled due to confusing false positives -->
+        <Or>
+            <Bug pattern="EI_EXPOSE_REP"/>
+            <Bug pattern="EI_EXPOSE_REP2"/>
+        </Or>
+    </Match>
 
 
     <!-- Do not check class -->