XWIKI-18007: Drawer menu improvements for accessibility #2225
Conversation
* Changed the drawer menu position, so it's next to its controller.
* Updated the drawer controls to close when focusing out and pressing escape * Moved the script from javascript.vm to flamingo.js * Added one style rule in drawer.less to hide elements from the tab order when the drawer is closed.
There was a problem hiding this comment.
While the code looks okay, I don't agree with the solution for moving focus out of the drawer. I think it is bad usability to close the drawer when the focus moves out of it. Imho, moving focus shouldn't close the drawer but rather focus should stay inside the drawer. Further, but less important, I think it would be good to add an explicit close button. It could, e.g., be positioned at the top left of the drawer outside the actual drawer area.
|
In regards to https://jira.xwiki.org/browse/XWIKI-21037, it seems like keeping the dependency on the Closing this PR because the solution does not seem appropriate to the situation. |
Jira: https://jira.xwiki.org/browse/XWIKI-18007
PR Changes
Video demo
https://up1.xwikisas.com/#BrnQdLpraMVHfWyF0be0og
Notes
This PR takes elements from #2075 and adds upon them more changes to fix the ticket completely.
Tests
mvn clean install -f xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/ -Pdocker,integration-tests,qualityfailed only on NavigationIT.navigateWithKeyboardShortcuts:142 and NavigationIT.docExtraLoadingFromTabClicks:164, which are build fails as of the 16th of June.