-
-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XWIKI-21009: LiveData alternative to drag controls #2809
Conversation
* Fixed the lost pointer cursor on the `sort` caret * Fixed broken translations
* Fixed the unexpected change in behavior for the resize handle. * Improved cursor on various elements to fit the features they should help use.
* Made the resize handles invisible when not focused again.
...ivedata/xwiki-platform-livedata-webjar/src/main/vue/layouts/table/LayoutTableHeaderNames.vue
Outdated
Show resolved
Hide resolved
Regarding the test command, I often user the following pattern:
|
Looks good, last remark. When a resize handle becomes visible, it's impacting the size of the column, leading to a small twitch. |
@@ -61,7 +60,8 @@ export const mousedownmove = { | |||
// Bind event listeners | |||
window.addEventListener("mousemove", mousemoveHandler); | |||
window.addEventListener("mouseup", removeMousemoveHandler); | |||
window.addEventListener("focusout", removeMousemoveHandler); | |||
// Stop propagation of the mousedown event |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe explain why the propagation stop is required (and what are the consequences otherwise).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked it again, and with the move I just made, it's not needed anymore.
* Moved the resize handle back to where it waws initially * Updated style to fit this new position * Removed a useless stoppropagation on an event
Thanks for this pattern! Keeping it in a safe place to use it on other PRs later on :)
Seems like was created by the changed position of the resize handle. I wanted to remove the absolute positioning of this handle by moving it, but it creates complications (also part of the reason why it was misplaced when dragging the rightmost column resizer to the left...) Here is a new demo of the changes. Executed testsSuccessfully passed |
Sure :) |
Jira URL
https://jira.xwiki.org/browse/XWIKI-21009
Changes
Description
sort
caretClarifications
Screenshots & Video
Demo video of the livedata after this PR
Executed Tests
No specific tests, built successfully
mvn clean install -f xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-webjar
Expected merging strategy