XWIKI-21618: The wizard step-done icons are hard coded #2820
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21618
Changes
Description
Screenshots & Video
Before the changes proposed in this PR:
![applicationWizardHardCoded](https://private-user-images.githubusercontent.com/28761965/299658848-9e94344f-0e37-45c7-b056-bf073167ffdc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5MjM3NzUsIm5iZiI6MTczOTkyMzQ3NSwicGF0aCI6Ii8yODc2MTk2NS8yOTk2NTg4NDgtOWU5NDM0NGYtMGUzNy00NWM3LWIwNTYtYmYwNzMxNjdmZmRjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE5VDAwMDQzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA3NWM0MDZlMmUwYzhlMTJhN2M4NWZhYjNlZDEwNThkMGEyYjIyZTVlMThkZmVhMDgyMmRjNzBmMDQwM2ZlZWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.qjiG2awsOrxvqpIf3pxdoiAqEESrH0ZGIFK2TENQcWc)
![21618-afterPRfa](https://private-user-images.githubusercontent.com/28761965/299658966-de2a2b7b-c55d-4781-8325-f24b827bd476.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5MjM3NzUsIm5iZiI6MTczOTkyMzQ3NSwicGF0aCI6Ii8yODc2MTk2NS8yOTk2NTg5NjYtZGUyYTJiN2ItYzU1ZC00NzgxLTgzMjUtZjI0YjgyN2JkNDc2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE5VDAwMDQzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk4ODNkMWVhNTEwZjVjMmYxMjIwMWQwNDk5ZmNlMzM4MzhjOGQxYTYzNjJjMjdiOWRmNjIwMjliYmRiZDg4NmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.HYPUjDqsFeTPXbvBUpjeN2aLVan9TVAhJm_1dNpC4q8)
![21618-afterPRsilk](https://private-user-images.githubusercontent.com/28761965/299659062-a461d03a-43ad-4685-855f-977c7466d1bf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5MjM3NzUsIm5iZiI6MTczOTkyMzQ3NSwicGF0aCI6Ii8yODc2MTk2NS8yOTk2NTkwNjItYTQ2MWQwM2EtNDNhZC00Njg1LTg1NWYtOTc3Yzc0NjZkMWJmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE5VDAwMDQzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZlMzU0MmM5ODY1ODQzMzU1NGVlMjUyMjUzYjMxMjNhYmM0Mzg2YzQxYmM1OTc3MThlZTA0Y2YxZjUzMzRhYWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.mhkuYFU3ipko_wUjAuiwsTRKkdqRTYyVVsowDgQVmYM)
After the changes proposed in this PR:
Font Awesome icon theme
Silk icon theme
Executed Tests
Only manual checks. From what I can see, there's no test covering elements related to .step-done .
Expected merging strategy