XWIKI-18994: Replace the Livetable of the Users and groups pages of the administration with a Live Data macro #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick feedback on the screenshots: the enable icon is now the same as the disable icon, is this intentional? |
michitux
reviewed
Mar 12, 2024
...dministration/xwiki-platform-administration-ui/src/main/resources/XWiki/AdminGroupsSheet.xml
Outdated
Show resolved
Hide resolved
| @@ -933,7 +933,7 @@ require(['jquery'], function($) { | |||
| /* Override general table styles. */ | |||
| /* TODO: Move to livetable.css */ | |||
There was a problem hiding this comment.
This to-do seems outdated after moving to Live Data.
There was a problem hiding this comment.
This comment is still up to date, as it still apply to the rights administration page table.
But yes, once all the LT for XS are migrated this comment will become outdated.
...administration/xwiki-platform-administration-ui/src/main/resources/XWiki/XWikiGroupSheet.xml
Outdated
Show resolved
Hide resolved
| */ | ||
| public List<WebElement> findElementsInRow(int rowNumber, By by) | ||
| { | ||
| return getRowElement(rowNumber).findElements(by); |
There was a problem hiding this comment.
Is it intentional that this is always waiting until the timeout? Or should this maybe use the variant without waiting?
...latform-web/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/widgets/modalPopup.css
Outdated
Show resolved
Hide resolved
manuelleduc
force-pushed
the
XWIKI-18994
branch
from
7833aee to
0befd57
Compare
This was indeed a mistake. I've fixed this. |
manuelleduc
force-pushed
the
XWIKI-18994
branch
from
0befd57 to
392988f
Compare
manuelleduc
changed the title
manuelleduc
force-pushed
the
XWIKI-18994
branch
from
392988f to
ce25e43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
Changes
Description
This was easier to change them all at the same time as they share some Javascript code to display modals.
Clarifications
Screenshots & Video
The screenshots have a red delete icon thanks to the separate PR #2972
Users administration
Main change: the actions are not right aligned anymore. I make things inconsistent with other actions.
Unless we want the actions to be right-aligned by default.
Before
After
Groups administration
Before
After
Users in group modal
Before
After
Sub Wiki users administration
Before
After
Sub Wiki groups administration
Before
After
Executed Tests
Expected merging strategy