Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-21967: Dragging to resize the columns from Affected Children Live Data causes the page to be deleted without user's confirmation #2953

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Mar 4, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-21967

Changes

Description

  • Added a type to the dragNdrop buttons to avoid them accidentally submitting a form they were included in.

Screenshots & Video

After the PR changes, the resize and reorder handles have type="button". They don't submit the form the LiveData is included in anymore.
21967-afterPR

Executed Tests

Successfully built mvn clean install -f xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-webjar -Pquality,integration-tests,docker.
After that, I included the JAR in my local distribution with ln -s -f ~/Documents/xwiki-platform/xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-webjar/target/xwiki-platform-livedata-webjar-16.2.0-SNAPSHOT.jar xwiki-platform-livedata-webjar-16.2.0-SNAPSHOT.jar in the folder /webapps/xwiki/WEB-INF/lib.
With the updated code on my local distrib, I was able to test out the bug (that I previously made sure to reproduce on this distrib with the old code). I couldn't reproduce the unexpected behavior reported with the updated code, and the DOM changed as expected (see screenshot above).

Expected merging strategy

…ve Data causes the page to be deleted without user's confirmation

* Added a type to the dragNdrop buttons to avoid them accidentally submitting a form they were included in.
@michitux michitux merged commit fbff860 into xwiki:master Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants