XWIKI-21967: Dragging to resize the columns from Affected Children Live Data causes the page to be deleted without user's confirmation #2953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21967
Changes
Description
Screenshots & Video
After the PR changes, the resize and reorder handles have
type="button"
. They don't submit the form the LiveData is included in anymore.Executed Tests
Successfully built
mvn clean install -f xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-webjar -Pquality,integration-tests,docker
.After that, I included the JAR in my local distribution with
ln -s -f ~/Documents/xwiki-platform/xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-webjar/target/xwiki-platform-livedata-webjar-16.2.0-SNAPSHOT.jar xwiki-platform-livedata-webjar-16.2.0-SNAPSHOT.jar
in the folder/webapps/xwiki/WEB-INF/lib
.With the updated code on my local distrib, I was able to test out the bug (that I previously made sure to reproduce on this distrib with the old code). I couldn't reproduce the unexpected behavior reported with the updated code, and the DOM changed as expected (see screenshot above).
Expected merging strategy