Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-21966: Cannot exit horizontal drop-down menu using accessibility tools #2956

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Mar 5, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-21966

Changes

Description

  • Added an event listener to close the currently navigated dropdown with Escape

Clarifications

  • When focusing menu dropdown, pressing escape will collapse it and focus the toggler.
  • Handling the focus manually is a thing to avoid. In this case:
    • the focus is on an element that got hidden, so we should move it to somewhere where it makes sense to have it
    • we don't move it far from the context we were in (only a couple tabs away in most cases)
    • we move it to an known and expected node

Screenshots & Video

Video demo to highlight the new behaviour

Executed Tests

Manual tests, see the video demo.
This component is not automatically tested (see changes in #2078, which did not break any test), so no further testing.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • 15.10.X : The changes are pretty safe and have a small scope.

…y tools

* Added an event listener to close the currently navigated dropdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable-15.10.x Used for automatic backport to 15.10.x branch. backport stable-16.4.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants