XWIKI-21747: Some filters cannot be activated on the Solr search results page when resizing the browser tab #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lts page when resizing the browser tab * L720-721: Fixed the display of the facet header when zooming,now using flex instead of inline. Thanks to those changes, the wrapping will not affect the dropdown button. * L764: Added a transition to smoothen out a state transition that was quite harsh * L766: removed an incorrect style * L820: set the text color on the toggler inside facets, that were a different shade of grey before.
…lts page when resizing the browser tab * Improved the separator line style to avoid it crossing down some header content when zooming in
Sereza7
added
the
backport stable-15.10.x
github-actions bot
pushed a commit
that referenced
this pull request
Mar 6, 2024
…lts page when resizing the browser tab (#2961) * L720-721: Fixed the display of the facet header when zooming, now using flex instead of inline. Thanks to those changes, the wrapping will not affect the dropdown button. * L764: Added a transition to smoothen out a state transition that was quite harsh * L766: removed an incorrect style * L820: set the text color on the toggler inside facets, that were a different shade of grey before. * Improved the separator line style to avoid it crossing down some header content when zooming in (cherry picked from commit b4bcc7a)
michitux
pushed a commit
that referenced
this pull request
Mar 6, 2024
…lts page when resizing the browser tab (#2961) * L720-721: Fixed the display of the facet header when zooming, now using flex instead of inline. Thanks to those changes, the wrapping will not affect the dropdown button. * L764: Added a transition to smoothen out a state transition that was quite harsh * L766: removed an incorrect style * L820: set the text color on the toggler inside facets, that were a different shade of grey before. * Improved the separator line style to avoid it crossing down some header content when zooming in (cherry picked from commit b4bcc7a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21747
Changes
Description
Clarification
Screenshots & Video
beforePR (Firefox 180% zoom)
afterPR (Firefox 180% zoom)
afterPR (Firefox 210% zoom - 3 lines wrapped) We can see that the separator line under the header is properly placed, unlike before. We decided to position it with
bottominside of giving it a hard coded margin-top that would lead to it crossing the header content when it wrapped on multiple lines.Executed Tests
None, style only changes, low scope and not hiding anything.
Expected merging strategy