-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for downloading important files #8 #11
Add support for downloading important files #8 #11
Conversation
ChiuchiuSorin
commented
Aug 31, 2023
•
edited
Loading
edited
- Created a rest API to access the server resources
- Created an interface to manipulate the server logs for different server types
- Created an endpoint for downloading the log archive and the necessary functions for downloading
- Created an endpoint for downloading XWiki files and the necessary functions for downloading
Created the pom structure of the project
# Conflicts: # application-admintools-default/pom.xml # application-admintools-default/src/main/resources/META-INF/components.txt
- Created an interface and abstract class DataProvider for better generalization and future extension of the components that provide data. - Created templates for data gathering components.
Rewrited some of the comments and corrected some typos.
Code refactoring
- Removed the download logs endpoint - Added an endpoint for downloading a multiple files archive - Added function for data providers to return info json - Added script function to retrieve the context path
- added logs viewer endpoint - merged with config-info
...mintools-default/src/main/java/com/xwiki/admintools/internal/downloads/DownloadsManager.java
Outdated
Show resolved
Hide resolved
# Conflicts: # application-admintools-api/src/main/java/com/xwiki/admintools/DataProvider.java # application-admintools-api/src/main/java/com/xwiki/admintools/ServerIdentifier.java # application-admintools-default/pom.xml # application-admintools-default/src/main/java/com/xwiki/admintools/internal/AdminToolsManager.java # application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/AbstractDataProvider.java # application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/ConfigurationDataProvider.java # application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/SecurityDataProvider.java # application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/identifiers/AbstractServerIdentifier.java # application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/identifiers/CurrentServer.java # application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/identifiers/TomcatIdentifier.java # application-admintools-default/src/main/java/com/xwiki/admintools/script/AdminToolsScriptService.java # application-admintools-default/src/main/resources/META-INF/components.txt
* Created a separated page for Javascript functions * Added user format to date picker * Adapted LogsDataResource * Adapted tests * Added and modified translations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to check also #11 (comment)
...cation-admintools-default/src/main/java/com/xwiki/admintools/internal/AdminToolsManager.java
Outdated
Show resolved
Hide resolved
...admintools-default/src/main/java/com/xwiki/admintools/internal/download/DownloadManager.java
Outdated
Show resolved
Hide resolved
...admintools-default/src/main/java/com/xwiki/admintools/internal/download/DownloadManager.java
Outdated
Show resolved
Hide resolved
...admintools-default/src/main/java/com/xwiki/admintools/internal/download/DownloadManager.java
Outdated
Show resolved
Hide resolved
application-admintools-api/src/main/java/com/xwiki/admintools/download/DataResource.java
Outdated
Show resolved
Hide resolved
...n/java/com/xwiki/admintools/internal/download/resources/XWikiPropertiesFileDataResource.java
Outdated
Show resolved
Hide resolved
...on-admintools-default/src/main/java/com/xwiki/admintools/script/AdminToolsScriptService.java
Outdated
Show resolved
Hide resolved
application-admintools-ui/src/main/resources/AdminTools/Code/AdminToolsJS.xml
Outdated
Show resolved
Hide resolved
application-admintools-ui/src/main/resources/AdminTools/WebHome.xml
Outdated
Show resolved
Hide resolved
* Modified comments and packages, classes and functions names * Removed parameter from downloadArchiveModal
application-admintools-api/src/main/java/com/xwiki/admintools/rest/AdminToolsResource.java
Outdated
Show resolved
Hide resolved
...ls-default/src/main/java/com/xwiki/admintools/internal/files/resources/LogsDataResource.java
Outdated
Show resolved
Hide resolved
...ools-default/src/main/java/com/xwiki/admintools/internal/rest/DefaultAdminToolsResource.java
Show resolved
Hide resolved
...ools-default/src/main/java/com/xwiki/admintools/internal/rest/DefaultAdminToolsResource.java
Outdated
Show resolved
Hide resolved
application-admintools-default/src/main/resources/templates/filesSectionTemplate.vm
Outdated
Show resolved
Hide resolved
application-admintools-ui/src/main/resources/AdminTools/Code/Macros.xml
Outdated
Show resolved
Hide resolved
* forgot to edit JS file
...main/java/com/xwiki/admintools/internal/files/resources/XWikiPropertiesFileDataResource.java
Outdated
Show resolved
Hide resolved
...main/java/com/xwiki/admintools/internal/files/resources/XWikiPropertiesFileDataResource.java
Outdated
Show resolved
Hide resolved
...main/java/com/xwiki/admintools/internal/files/resources/XWikiPropertiesFileDataResource.java
Show resolved
Hide resolved
...main/java/com/xwiki/admintools/internal/files/resources/XWikiPropertiesFileDataResource.java
Outdated
Show resolved
Hide resolved
* Modified files exception handling
...ools-default/src/main/java/com/xwiki/admintools/internal/data/ConfigurationDataProvider.java
Outdated
Show resolved
Hide resolved
...ls-default/src/main/java/com/xwiki/admintools/internal/files/resources/LogsDataResource.java
Outdated
Show resolved
Hide resolved
...ls-default/src/main/java/com/xwiki/admintools/internal/files/resources/LogsDataResource.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/xwiki/admintools/internal/files/resources/XWikiConfigFileDataResource.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/xwiki/admintools/internal/files/resources/XWikiConfigFileDataResource.java
Outdated
Show resolved
Hide resolved
...main/java/com/xwiki/admintools/internal/files/resources/XWikiPropertiesFileDataResource.java
Outdated
Show resolved
Hide resolved
...main/java/com/xwiki/admintools/internal/files/resources/XWikiPropertiesFileDataResource.java
Outdated
Show resolved
Hide resolved
* Modified exception handling * Added comments
application-admintools-api/src/main/java/com/xwiki/admintools/ServerIdentifier.java
Outdated
Show resolved
Hide resolved
...ools-default/src/main/java/com/xwiki/admintools/internal/data/ConfigurationDataProvider.java
Outdated
Show resolved
Hide resolved
...intools-default/src/main/java/com/xwiki/admintools/internal/files/ImportantFilesManager.java
Outdated
Show resolved
Hide resolved
...intools-default/src/main/java/com/xwiki/admintools/internal/files/ImportantFilesManager.java
Outdated
Show resolved
Hide resolved
...intools-default/src/main/java/com/xwiki/admintools/internal/files/ImportantFilesManager.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/xwiki/admintools/internal/files/resources/XWikiConfigFileDataResource.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/xwiki/admintools/internal/files/resources/XWikiConfigFileDataResource.java
Outdated
Show resolved
Hide resolved
...main/java/com/xwiki/admintools/internal/files/resources/XWikiPropertiesFileDataResource.java
Outdated
Show resolved
Hide resolved
application-admintools-api/src/main/java/com/xwiki/admintools/download/DataResource.java
Outdated
Show resolved
Hide resolved
application-admintools-ui/src/main/resources/AdminTools/Code/AdminToolsJS.xml
Outdated
Show resolved
Hide resolved
* Modified comments * Modified Exception and logger messages
...admintools-api/src/main/java/com/xwiki/admintools/configuration/AdminToolsConfiguration.java
Show resolved
Hide resolved
...intools-default/src/main/java/com/xwiki/admintools/internal/files/ImportantFilesManager.java
Outdated
Show resolved
Hide resolved
* Code refactoring for filters handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments
application-admintools-api/src/main/java/com/xwiki/admintools/download/DataResource.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/xwiki/admintools/internal/files/resources/XWikiConfigFileDataResource.java
Outdated
Show resolved
Hide resolved
...main/java/com/xwiki/admintools/internal/files/resources/XWikiPropertiesFileDataResource.java
Outdated
Show resolved
Hide resolved
# Conflicts: # application-admintools-api/src/main/java/com/xwiki/admintools/ServerIdentifier.java # application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/ConfigurationDataProvider.java # application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/identifiers/TomcatIdentifier.java # application-admintools-default/src/main/resources/META-INF/components.txt # application-admintools-default/src/main/resources/templates/configurationTemplate.vm # application-admintools-default/src/test/java/com/xwiki/admintools/internal/data/ConfigurationDataProviderTest.java
* Merged with main branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small change, otherwise it looks good:)
Please don't forget to update the associated issue with updated screenshots
application-admintools-ui/src/main/resources/AdminTools/Code/Translations.xml
Show resolved
Hide resolved
* Modified the minimum supported version from 13.10 to 14.10