Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for downloading important files #8 #11

Merged
merged 53 commits into from
Nov 2, 2023

Conversation

ChiuchiuSorin
Copy link
Collaborator

@ChiuchiuSorin ChiuchiuSorin commented Aug 31, 2023

  • Created a rest API to access the server resources
  • Created an interface to manipulate the server logs for different server types
  • Created an endpoint for downloading the log archive and the necessary functions for downloading
  • Created an endpoint for downloading XWiki files and the necessary functions for downloading

Created the pom structure of the project
# Conflicts:
#	application-admintools-default/pom.xml
#	application-admintools-default/src/main/resources/META-INF/components.txt
- Created an interface and abstract class DataProvider for better generalization and  future extension of the components that provide data.
- Created templates for data gathering components.
Rewrited some of the comments and corrected some typos.
@ChiuchiuSorin ChiuchiuSorin self-assigned this Aug 31, 2023
- Removed the download logs endpoint
- Added an endpoint for downloading a multiple files archive
- Added function for data providers to return info json
- Added script function to retrieve the context path
- added logs viewer endpoint
- merged with config-info
# Conflicts:
#	application-admintools-api/src/main/java/com/xwiki/admintools/DataProvider.java
#	application-admintools-api/src/main/java/com/xwiki/admintools/ServerIdentifier.java
#	application-admintools-default/pom.xml
#	application-admintools-default/src/main/java/com/xwiki/admintools/internal/AdminToolsManager.java
#	application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/AbstractDataProvider.java
#	application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/ConfigurationDataProvider.java
#	application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/SecurityDataProvider.java
#	application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/identifiers/AbstractServerIdentifier.java
#	application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/identifiers/CurrentServer.java
#	application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/identifiers/TomcatIdentifier.java
#	application-admintools-default/src/main/java/com/xwiki/admintools/script/AdminToolsScriptService.java
#	application-admintools-default/src/main/resources/META-INF/components.txt
* Created a separated page for Javascript functions
* Added user format to date picker
* Adapted LogsDataResource
* Adapted tests
* Added and modified translations
Copy link

@oanalavinia oanalavinia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to check also #11 (comment)

* Modified comments and packages, classes and functions names
* Removed parameter from downloadArchiveModal
* Modified files exception handling
* Modified exception handling
* Added comments
* Modified comments
* Modified Exception and logger messages
* Code refactoring for filters handling
Copy link

@oanalavinia oanalavinia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments

# Conflicts:
#	application-admintools-api/src/main/java/com/xwiki/admintools/ServerIdentifier.java
#	application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/ConfigurationDataProvider.java
#	application-admintools-default/src/main/java/com/xwiki/admintools/internal/data/identifiers/TomcatIdentifier.java
#	application-admintools-default/src/main/resources/META-INF/components.txt
#	application-admintools-default/src/main/resources/templates/configurationTemplate.vm
#	application-admintools-default/src/test/java/com/xwiki/admintools/internal/data/ConfigurationDataProviderTest.java
Copy link

@oanalavinia oanalavinia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change, otherwise it looks good:)
Please don't forget to update the associated issue with updated screenshots

* Modified the minimum supported version from 13.10 to 14.10
@ChiuchiuSorin ChiuchiuSorin merged commit c210ec0 into xwikisas:main Nov 2, 2023
@ChiuchiuSorin ChiuchiuSorin deleted the files-logs-download branch November 2, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants