Replace arrays with sets for faster lookup.

y-scope · Dec 31, 2024 · 58a434c · 58a434c
1 parent 13192bd
commit 58a434c
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/components/log-viewer-webui/server/src/DbManager.ts b/components/log-viewer-webui/server/src/DbManager.ts
@@ -250,7 +250,7 @@ class DbManager {
             }
             const status = job[QUERY_JOBS_TABLE_COLUMN_NAMES.STATUS];
 
-            if (false === QUERY_JOB_STATUS_WAITING_STATES.includes(status)) {
+            if (false === QUERY_JOB_STATUS_WAITING_STATES.has(status)) {
                 if (QUERY_JOB_STATUS.CANCELLED === status) {
                     throw new Error(`Job ${jobId} was cancelled.`);
                 } else if (QUERY_JOB_STATUS.SUCCEEDED !== status) {

diff --git a/components/log-viewer-webui/server/src/main.ts b/components/log-viewer-webui/server/src/main.ts
@@ -9,6 +9,11 @@ import app from "./app.js";
 
 
 type NodeEnv = "development" | "production" | "test";
+const KNOWN_NODE_ENVS = new Set<NodeEnv>([
+    "development",
+    "production",
+    "test",
+]);
 
 const NODE_ENV_DEFAULT: NodeEnv = "development";
 
@@ -33,11 +38,7 @@ const ENV_TO_LOGGER
  * @return True if the `value` is a known Node.js environment; otherwise, false.
  */
 const isKnownNodeEnv = (value: string): value is NodeEnv => {
-    return [
-        "development",
-        "production",
-        "test",
-    ].includes(value);
+    return KNOWN_NODE_ENVS.has(value as NodeEnv);
 };
 
 interface EnvVars {

diff --git a/components/log-viewer-webui/server/src/routes/query.ts b/components/log-viewer-webui/server/src/routes/query.ts
@@ -27,7 +27,7 @@ const routes: FastifyPluginAsync = async (app) => {
         },
     }, async (req, resp) => {
         const {extractJobType, logEventIdx, streamId} = req.body;
-        if (false === EXTRACT_JOB_TYPES.includes(extractJobType)) {
+        if (false === EXTRACT_JOB_TYPES.has(extractJobType)) {
             resp.code(StatusCodes.BAD_REQUEST);
             throw new Error(`Invalid extractJobType="${extractJobType}".`);
         }

diff --git a/components/log-viewer-webui/server/src/typings/DbManager.ts b/components/log-viewer-webui/server/src/typings/DbManager.ts
@@ -13,7 +13,7 @@ enum QUERY_JOB_TYPE {
 /**
  * List of valid extract job types.
  */
-const EXTRACT_JOB_TYPES = Object.freeze([
+const EXTRACT_JOB_TYPES = new Set([
     QUERY_JOB_TYPE.EXTRACT_IR,
     QUERY_JOB_TYPE.EXTRACT_JSON,
 ]);
@@ -36,7 +36,7 @@ enum QUERY_JOB_STATUS {
 /**
  * List of states that indicate the job is either pending or in progress.
  */
-const QUERY_JOB_STATUS_WAITING_STATES = Object.freeze([
+const QUERY_JOB_STATUS_WAITING_STATES = new Set([
     QUERY_JOB_STATUS.PENDING,
     QUERY_JOB_STATUS.RUNNING,
     QUERY_JOB_STATUS.CANCELLING,